Closed Bug 1421635 Opened 7 years ago Closed 7 years ago

Crash in aom_highbd_convolve8_add_src_hip_ssse3

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Platform:
x86
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: marcia, Assigned: rillian)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Bug 1421635 - av1: Disable decoding on 32-bit x86.
59 bytes, text/x-review-board-request
kinetik
: review+
Details 
This bug was filed from the Socorro interface and is
report bp-152698d4-0606-4969-b7ab-d4d380171129.
=============================================================

Seen while looking at nightly crash data: http://bit.ly/2AH9sD9. Looks as if only 2 people may be crashing. Crashes started using Build ID 20171119100329 .

Top 10 frames of crashing thread:

0 xul.dll aom_highbd_convolve8_add_src_hip_ssse3 third_party/aom/aom_dsp/x86/aom_highbd_convolve_hip_ssse3.c:178
1 xul.dll loop_wiener_filter_tile_highbd third_party/aom/av1/common/restoration.c:1273
2 xul.dll loop_wiener_filter_highbd third_party/aom/av1/common/restoration.c:1337
3 xul.dll loop_restoration_rows third_party/aom/av1/common/restoration.c:1699
4 xul.dll av1_loop_restoration_frame third_party/aom/av1/common/restoration.c:1770
5 xul.dll av1_decode_tg_tiles_and_wrapup third_party/aom/av1/decoder/decodeframe.c:5753
6 xul.dll av1_receive_compressed_data third_party/aom/av1/decoder/decoder.c:371
7 xul.dll frame_worker_hook third_party/aom/av1/av1_dx_iface.c:385
8 xul.dll execute third_party/aom/aom_util/aom_thread.c:134
9 xul.dll decode_one third_party/aom/av1/av1_dx_iface.c:560

=============================================================
About 5 or 6 reports are from me trying the newly available AV1 demo at https://demo.bitmovin.com/public/firefox/av1/. (Blog post was released yesterday at https://hacks.mozilla.org/2017/11/dash-playback-of-av1-video/.)
Sometimes a visit to the AV1 page even without playing (but buffering?) the video will trigger a crash.

I'm using Windows 10 latest release with all patches, and Nvidia GTX760 with driver 388.31 (latest release). Crash happens with or without a new profile.

Media related information in about:support:

Graphics
--------

Features
Compositing: Direct3D 11 (Advanced Layers)
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
WebGL 1 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 0000000000008c21) EGL_VERSION: 1.4 (ANGLE 2.1.0.db3422764a9b) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_ANGLE_display_robust_resource_initialization
WebGL 1 Driver Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GTX 760 Direct3D11 vs_5_0 ps_5_0)
WebGL 1 Driver Version: OpenGL ES 2.0 (ANGLE 2.1.0.db3422764a9b)
WebGL 1 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 0000000000008c21) EGL_VERSION: 1.4 (ANGLE 2.1.0.db3422764a9b) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_ANGLE_display_robust_resource_initialization
WebGL 2 Driver Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GTX 760 Direct3D11 vs_5_0 ps_5_0)
WebGL 2 Driver Version: OpenGL ES 3.0 (ANGLE 2.1.0.db3422764a9b)
WebGL 2 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_multiview GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
Direct2D: true
Off Main Thread Painting Enabled: true
DirectWrite: true (10.0.16299.15)
GPU #1
Active: Yes
Description: NVIDIA GeForce GTX 760
Vendor ID: 0x10de
Device ID: 0x1187
Driver Version: 23.21.13.8831
Driver Date: 11-14-2017
Drivers: C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumdx.dll C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_c791f781cd94491f\nvldumd.dll
Subsys ID: 282b1462
RAM: 4096
GPU #2
Active: No
Description: Intel(R) HD Graphics 4600
Vendor ID: 0x8086
Device ID: 0x0412
Driver Version: 20.19.15.4703
Driver Date: 6-9-2017
Drivers: igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32
Subsys ID: 0000000c
RAM: Unknown
Diagnostics
ClearType Parameters: DISPLAY1 [ Gamma: 2.2 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ] DISPLAY2 [ Gamma: 2.4 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ]
AzureCanvasAccelerated: 0
AzureCanvasBackend: Direct2D 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: Direct2D 1.1
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): cairo
GPUProcessPid: 4856
GPUProcess: Terminate GPU Process
Device Reset: Trigger Device Reset
ClearType Parameters: DISPLAY1 [ Gamma: 2.2 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ] DISPLAY2 [ Gamma: 2.4 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ]
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature




Media
-----

Audio Backend: wasapi
Max Channels: 2
Preferred Channel Layout: stereo
Preferred Sample Rate: 48000
Output Devices
Name: Group
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
Realtek Digital Output (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
2367-4 (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
Speakers (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Input Devices
Name: Group
Line In (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
Microphone (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Subwoofer (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
Rear (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
FrontMic (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Stereo Mix (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Line In (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Front (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
FrontMic (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Center (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Side (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Microphone (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0900&SUBSYS_18491151&REV_1000\4&1902e5e1&0&0001
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0040&SUBSYS_1462282B&REV_1001\5&27a068fd&0&0001
Flags: needinfo?(giles)
Priority: -- → P3
The socorro reports are all on 32-bit Windows 7. Comment #1 is Windows 10, but I can't tell if it's 32-bit. I haven't seen this, but I have 64-bit Windows 10.

The crashing line is _mm_unpackhi_epi64 (PUNPCKHQDQ) is is just splating ints which are hopefully already in a SIMD register, so it's hard to see how this could be an out-of-bounds read. Maybe something's misaligned. Maybe the stack is corrupt and the problem has nothing to do with that particular line.

The best way to get more information would be to examine the local variables in a debugger at the crash site. Fanolian, is that something you'd be comfortable doing?
Flags: needinfo?(giles) → needinfo?(Fanolian+bugzilla)
(In reply to Ralph Giles (:rillian) | needinfo me from comment #2)
> The best way to get more information would be to examine the local variables
> in a debugger at the crash site. Fanolian, is that something you'd be
> comfortable doing?

I am sorry I do not know how to do it.

I did some more testings. Using 2017-12-01 build, the site crashes only with 32bit Nightly.
64bit Win10 + 64bit Nightly = No crash
64bit Win10 + 32bit Nightly = Crash
Flags: needinfo?(Fanolian+bugzilla) → needinfo?(giles)
Ok, that's fine. Thanks for the additional testing, that was very helpful. With the information at it's reproducible with 32-bit Nightly on 64-bit Windows 10, I was able to reproduce a crash. Trying to get a debugger view to answer my questions above.
Assignee: nobody → giles
Flags: needinfo?(giles)
I spent quite a bit of time on this but wasn't able to get any more useful information. I couldn't reproduce the crash with a 32-bit Linux build, only on Windows.

Since most of our users are on 64-bit builds now, I'm going to address this by just disabling the demo for 32-bit x86 targets.
Comment on attachment 8934751 [details]
Bug 1421635 - av1: Disable decoding on 32-bit x86.

https://reviewboard.mozilla.org/r/205628/#review211226
Attachment #8934751 - Flags: review?(kinetik) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26f48e5e1f55
av1: Disable decoding on 32-bit x86. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/26f48e5e1f55
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
If only you knew someone who likes debugging disassembly. :)

The crashing instruction is a `punpcklwd` which requires an xmmword (16-byte) aligned memory argument. Unaligned SSE accesses can result in bogus 0xffffffff crash addresses. In each crash report, the instruction is accessing an address ending in hex digit 8, so unaligned.

By (good|bad) luck, the previous instructions in this block were unaligned-tolerant `movups` instructions. So I think the root of this problem starts a bit earlier than the line reporting the crash.

As a first guess I'd say `data` is suspicious here, maybe it and all related variables need some kind of alignment guarantee: https://hg.mozilla.org/mozilla-central/annotate/c2248f853469/third_party/aom/aom_dsp/x86/aom_highbd_convolve_hip_ssse3.c#l141
Flags: needinfo?(giles)
I guess another way to say it is: anything that gets cast to __m128i* should be aligned.
Wow, thanks for the analysis! I looked at that and saw that the increment is by multiples of MAX_SB_SIZE (64 or 128 elements) and j increments by 8, which on an int16_t* is 16 bytes. I didn't think about the base address. Is there something in x86_64 ABI that results in temp being aligned, or is it just an accident?
Flags: needinfo?(giles)
Depends on: 1423814
> Is there something in x86_64 ABI that results in temp being aligned, or is it just an accident?

Both! The ABI aligns the stack to 16 bytes, and (assuming things got laid out in order) there happen to be two void* variables preceding `temp`, maintaining the 16 bytes.
Noticed a reduce installer size on Linux and Windows 32Bit:

== Change summary for alert #10890 (as of Wed, 06 Dec 2017 00:44:42 GMT) ==

Improvements:

  2%  installer size windows2012-32 pgo      57,443,657.00 -> 56,565,218.17
  1%  installer size linux32 pgo             64,242,622.17 -> 63,515,768.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10890
Also noticed these Talos improvements:

== Change summary for alert #10891 (as of Wed, 06 Dec 2017 00:44:42 GMT) ==

Improvements:

  5%  tp5n main_startup_fileio windows7-32 opt e10s     68,403,219.83 -> 64,985,519.67
  5%  tp5n main_startup_fileio windows7-32 pgo e10s     70,870,436.42 -> 67,467,416.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10891
Oh my. I take it the disabler-change actually removes the av1 code from the build? 900k is a lot! I'm almost tempted to suggest leaving it off. :) How is bug 1412889 looking?
Indeed. Luckily it's nightly-only for the moment. I haven't looked at it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: