1421655 - browser.clipboard.setImageData Only Works with a Small Amount of Data

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Barry Chen]

Bug 1356543 introduced browser.clipboard.setImageData, which is now used in Screenshots.  However, there's a regression starting with the 2017-11-27-22-04-46 build of Nightly.  I think it came from bug 1420223.  More specifically: https://hg.mozilla.org/mozilla-central/diff/e60f002f07d0/toolkit/components/extensions/ext-clipboard.js#l1.32  That `apply` call will hit the function argument length limit.

STR

1. Google image search something with latest Nightly.  Page down to the bottom.
2. Start Screenshots and select save full page.
3. Click the copy button.

Expected

Image successfully copied to system clipboard.

Actual

Error notification.

The error message itself is also incorrect and misleading because the catch block did not make use of the exception.

Comment 1

[Ian Bicking (:ianbicking)]

Note this is causing a critical bug in the Screenshots' copy feature: https://github.com/mozilla-services/screenshots/issues/3850

Comment 2

[Andy McKay]

Based on comment 0, pinging :baku.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 1 - introducing imgITool::decodeImageFromArrayBuffer

The problem here is that we are copy the buffer too much and we end up reaching the limit of the string size. Let's use arrayBuffer instead.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 2 - Implementation of imgITool::decodeImageFromArrayBuffer

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 3 - renaming imgITool::decodeImageBuffer to decodeImageFromBuffer

To be consistent with the other method.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2dff894a6dd
Using imgITools::decodeImageFromArrayBuffer instead coping data into a string, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/807297ac2445
Implementation of imgITools::decodeImageFromArrayBuffer, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/75d2ae4d07c4
Renaming imgITools::decodeImageBuffer to imgITools::decodeImageFromBuffer, r=aosmond

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d2dff894a6dd
https://hg.mozilla.org/mozilla-central/rev/807297ac2445
https://hg.mozilla.org/mozilla-central/rev/75d2ae4d07c4

Comment 8

[marius.santa]

Attachment: not blurred.PNG

I can reproduce this issue on Firefox 59.0a1 (20171128220048) under Wind 10 64-bit. 

This issue is verified as fixed on Firefox 59.0a1 (20171205100345) under Wind 10 64-bit and Mac OS X 10.13.