1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #1419096 +++

Bug 1419096 comment 11 pointed out that we need to specify both the 0% and 100% values of @keyframes for current optimizations to apply.

The patches in this bug will add default start or end values to @keyframes in mozilla-central so they will be available for optimizations.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'm waiting for a response to https://bugzilla.mozilla.org/show_bug.cgi?id=1419096#c16 before I attach the patch here. Flagging myself for needinfo...

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both.

Review commit: https://reviewboard.mozilla.org/r/204028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204028/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8933065 [details]
Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both.

https://reviewboard.mozilla.org/r/204028/#review209814

::: browser/themes/shared/customizableui/customizeMode.inc.css:669
(Diff revision 1)
>    animation: game-over 4s forwards ease;
>  }
>  
>  @keyframes game-over {
> +  0% {
> +    transform: scale(1) translateY(0) rotateZ(0);

Do we have to set the initial opacity here?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8933065 [details]
Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both.

https://reviewboard.mozilla.org/r/204028/#review209824

::: browser/themes/shared/customizableui/customizeMode.inc.css:669
(Diff revision 1)
>    animation: game-over 4s forwards ease;
>  }
>  
>  @keyframes game-over {
> +  0% {
> +    transform: scale(1) translateY(0) rotateZ(0);

Yeah, good call. I'll fix it up and land this. Thanks!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8933065 [details]
Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204028/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09b116a802ff
Explicitly declare the start/end values of CSS animations since optimizations require both. r=mconley

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/09b116a802ff