Get rid of a warning message in nsFileInputStream DTOR

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
In the DTOR of nsFileInputStream, Close() is executed, and this tries to call Tell() in order to rewind the stream. This is not needed in the DTOR and we can avoid having a warning message for this.
Assignee

Comment 1

2 years ago
Posted patch warning.patchSplinter Review
Attachment #8932965 - Flags: review?(kyle)
Attachment #8932965 - Flags: review?(kyle) → review+
Priority: -- → P2

Comment 2

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be95a1123de4
Get rid of nsFileInputStream::Tell warning message when nsFileInputStream is destroyed, r=qdot

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be95a1123de4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.