Closed Bug 1421728 Opened 2 years ago Closed 2 years ago

Create Cross-compile fuzzing build on Taskcluster

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla60

People

(Reporter: rforbes, Assigned: truber)

References

Details

Attachments

(1 file)

We need a fuzzing build similar to linux64-asan-fuzzing/opt but for macosx64 cross-compile.
Depends on: 1425406
Assignee: nobody → jschwartzentruber
No longer depends on: 1421755
Comment on attachment 8950937 [details]
Bug 1421728 - Add a macosx64 fuzzing-asan build.

https://reviewboard.mozilla.org/r/220190/#review226264
Attachment #8950937 - Flags: review?(dustin) → review+
Comment on attachment 8950937 [details]
Bug 1421728 - Add a macosx64 fuzzing-asan build.

https://reviewboard.mozilla.org/r/220190/#review226068

WFM.  Two small-ish things below.

::: testing/mozharness/configs/builds/releng_sub_mac_configs/64_cross_fuzzing_asan.py:7
(Diff revision 1)
> +
> +config = {
> +    'default_actions': [
> +        'clobber',
> +        'build',
> +        'check-test',

This step would try to run target binaries on the host, wouldn't it?  I don't see it listed in the other cross configs, which makes me think that we don't want it...

::: testing/mozharness/configs/builds/releng_sub_mac_configs/64_cross_fuzzing_asan.py:17
(Diff revision 1)
> +    'platform_supports_post_upload_to_latest': False,
> +    'enable_signing': False,
> +    #### 64 bit build specific #####
> +    'env': {
> +        'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
> +        'MOZ_AUTOMATION': '1',

I don't think this is necessary anymore; taskcluster sets this itself.  (I realize this is present in other configs.)
Attachment #8950937 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #4)
Thanks, I removed both and the build still succeeds.
Keywords: checkin-needed
Sorry, this cannot be landed because there are 2 opened issues. Please mark them as fixed. Thank you!
Flags: needinfo?(jschwartzentruber)
Keywords: checkin-needed
Done.
Flags: needinfo?(jschwartzentruber)
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/907a3ecfa24c
Add a macosx64 fuzzing-asan build. r=dustin,froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/907a3ecfa24c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1209937
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.