Closed Bug 1421791 Opened 2 years ago Closed 2 years ago

move --enable-{ion,simulator} definitions to moz.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

--enable-ion was only used by --enable-simulator and related options, so
there wasn't much point in making two separate commits.

This translation is a little more verbose than the original
old-configure code, but I think it is more readable and easier to
follow.  We also don't port over --enable-simulator=no, as there doesn't
seem to be much point in doing so.
Attachment #8933049 - Flags: review?(core-build-config-reviews)
Comment on attachment 8933049 [details] [diff] [review]
move --enable-{ion,simulator} definitions to moz.configure

Review of attachment 8933049 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.
Attachment #8933049 - Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08fb3c18e98d
move --enable-{ion,simulator} definitions to moz.configure; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/08fb3c18e98d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.