1421792 - move --enable-trace-logging to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move --enable-trace-logging to moz.configure

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8933051 [details] [diff] [review]
move --enable-trace-logging to moz.configure

Review of attachment 8933051 [details] [diff] [review]:
-----------------------------------------------------------------

Technically, this looks fine.  However, I see only one real use of ENABLE_TRACE_LOGGING (see https://searchfox.org/mozilla-central/search?q=ENABLE_TRACE_LOGGING&path=); we should cull that variable and just use JS_TRACE_LOGGING.  I suppose this could bite somebody, but the fix is easy enough, and we could email if we were really concerned.  (Deprecation code isn't worth the effort in my opinion.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9231cda92d8
move --enable-trace-logging to moz.configure; r=nalexander

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed8eade7d0d1
Backout f9231cda92d8 on suspicion of causing inscrutable moz.configure lint errors; r=bustage

Comment 5

[Mike Hommey [:glandium]]

The error is inscrutable because of the wrapping in depends_if. I /think/ we could change the depends_if implementation to something like:

depends(foo, when=foo)

when there's only one argument to depends_if.

It also means you should actually be able to change your depends_if to depends(when=moz_debug)(lambda: True)

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> The error is inscrutable because of the wrapping in depends_if. I /think/ we
> could change the depends_if implementation to something like:
> 
> depends(foo, when=foo)
> 
> when there's only one argument to depends_if.

This breaks some other usages of @depends_if.

> It also means you should actually be able to change your depends_if to
> depends(when=moz_debug)(lambda: True)

But this works.

depends_if is more useful if you actually need more than the truthness of the option being enabled (because you get the value as an argument). With depends(when=...), you just pass a function/lambda with no arguments.

You can also change the depends_if in the set_config/set_define, but only the one for the option default is causing lint trouble.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e92a30a9d52
move --enable-trace-logging to moz.configure; r=nalexander

Comment 8

[Nathan Froyd [:froydnj]]

Pushed with the depends(when=moz_debug) change.  Thanks for the debugging assistance, glandium!

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9e92a30a9d52