Don't use signature hashes for persisting selected data points in perfherder graphs

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

One last remnant of the old signature hashes is the selected url serialization. e.g.:

https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1315740,1,1&selected=%5Bmozilla-inbound,3dad3177b3cd74880dd33d4e43279ffea0f0347d,280593,373123625,1%5D

It would be best if we could use integer ids for identifying the series. Something like this, in other words:

https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1315740,1,1&selected=mozilla-inbound,1315740,283351,377865383,1

This is shorter, and further paves the way to removing signature hashes entirely from perfherder someday.
Comment on attachment 8933094 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3002

Could you review this one Rob?
Attachment #8933094 - Flags: review?(rwood)

Comment 3

2 months ago
Comment on attachment 8933094 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3002

Nice, LGTM
Attachment #8933094 - Flags: review?(rwood) → review+

Comment 4

2 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b1d8fd4e1995641edba4e694a95b672ac2ed3d03
Bug 1421809 - Shorten perfherder graph urls when datapoint is selected (#3002)

This also fixes linking to specific datapoints on the graph from the job
detail view, which was broken. Note that the links are not backwards
compatible, but people linking to selected datapoints in graphs is pretty
rare (and the links are highly time-sensitive in any case).
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Blocks: 1329224
You need to log in before you can comment on or make changes to this bug.