1421875 - Move MediaDecoder::NotifyDataArrived() down the class hierarchy

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

This will facilitate our refactoring of ChannelMediaDecoder/MediaCache.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1421875. P1 - rename MediaDecoder::NotifyDataArrivedInternal().

Review commit: https://reviewboard.mozilla.org/r/204462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204462/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1421875. P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy.

For it is never used by ChannelMediaDecoder.

Review commit: https://reviewboard.mozilla.org/r/204464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204464/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1421875. P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed().

Also devirtualize ChannelMediaDecoder::DownloadProgressed() and move it to private.

Review commit: https://reviewboard.mozilla.org/r/204466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204466/

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8933517 [details]
Bug 1421875. P1 - rename MediaDecoder::NotifyDataArrivedInternal().

https://reviewboard.mozilla.org/r/204462/#review209996

Comment 5

[Benjamin Chen [:bechen]]

Comment on attachment 8933518 [details]
Bug 1421875. P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy.

https://reviewboard.mozilla.org/r/204464/#review210000

Comment 6

[Benjamin Chen [:bechen]]

Comment on attachment 8933519 [details]
Bug 1421875. P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed().

https://reviewboard.mozilla.org/r/204466/#review210002

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8933517 [details]
Bug 1421875. P1 - rename MediaDecoder::NotifyDataArrivedInternal().

https://reviewboard.mozilla.org/r/204462/#review210010

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8933518 [details]
Bug 1421875. P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy.

https://reviewboard.mozilla.org/r/204464/#review210012

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8933519 [details]
Bug 1421875. P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed().

https://reviewboard.mozilla.org/r/204466/#review210014

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ee65d949c5
P1 - rename MediaDecoder::NotifyDataArrivedInternal(). r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/ef7f09a38f92
P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/7872c5484cd1
P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed(). r=bechen,gerald

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b6ee65d949c5
https://hg.mozilla.org/mozilla-central/rev/ef7f09a38f92
https://hg.mozilla.org/mozilla-central/rev/7872c5484cd1