Closed Bug 1421875 Opened 4 years ago Closed 4 years ago

Move MediaDecoder::NotifyDataArrived() down the class hierarchy

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

This will facilitate our refactoring of ChannelMediaDecoder/MediaCache.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8933517 - Flags: review?(bechen)
Attachment #8933518 - Flags: review?(bechen)
Attachment #8933519 - Flags: review?(bechen)
Comment on attachment 8933517 [details]
Bug 1421875. P1 - rename MediaDecoder::NotifyDataArrivedInternal().

https://reviewboard.mozilla.org/r/204462/#review209996
Attachment #8933517 - Flags: review?(bechen) → review+
Comment on attachment 8933518 [details]
Bug 1421875. P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy.

https://reviewboard.mozilla.org/r/204464/#review210000
Attachment #8933518 - Flags: review?(bechen) → review+
Comment on attachment 8933519 [details]
Bug 1421875. P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed().

https://reviewboard.mozilla.org/r/204466/#review210002
Attachment #8933519 - Flags: review?(bechen) → review+
Attachment #8933517 - Flags: review?(gsquelart)
Attachment #8933518 - Flags: review?(gsquelart)
Attachment #8933519 - Flags: review?(gsquelart)
Comment on attachment 8933517 [details]
Bug 1421875. P1 - rename MediaDecoder::NotifyDataArrivedInternal().

https://reviewboard.mozilla.org/r/204462/#review210010
Attachment #8933517 - Flags: review?(gsquelart) → review+
Comment on attachment 8933518 [details]
Bug 1421875. P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy.

https://reviewboard.mozilla.org/r/204464/#review210012
Attachment #8933518 - Flags: review?(gsquelart) → review+
Comment on attachment 8933519 [details]
Bug 1421875. P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed().

https://reviewboard.mozilla.org/r/204466/#review210014
Attachment #8933519 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6ee65d949c5
P1 - rename MediaDecoder::NotifyDataArrivedInternal(). r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/ef7f09a38f92
P2 - move MediaDecoder::NotifyDataArrived() down the class hierarchy. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/7872c5484cd1
P3 - remove MediaDecoder::DownloadProgressed() which is basically a one-line call to GetOwner()->DownloadProgressed(). r=bechen,gerald
You need to log in before you can comment on or make changes to this bug.