1421877 - Fix warning spam in EditorDOMPointBase

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

EditorDOMPointBase has some wrong NS_WARNING_ASSERTION. They cause a lot of warning spam.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=deda81425a03aa553ccb1c66eda7bfdfdcb63897

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1421877 - Fix some warnings which hit (almost) always in EditorDOMPointBase

There are 3 spam warning assertion in EditorDOMPointBase.

One is in constructor. Which warns if IsSet() returns false, but it checks
before finishing initializing.

The others are in IsStartOfContainer() and IsEndOfContainer().  They try to
check if mOffset is valid value with current DOM tree if it's initialized
when it's at start or end of the container.  However, they do it even when
it's not start nor end of the container.

This patch fixes those spammers.

Review commit: https://reviewboard.mozilla.org/r/204146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204146/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8933204 [details]
Bug 1421877 - Fix some warnings which hit (almost) always in EditorDOMPointBase

https://reviewboard.mozilla.org/r/204146/#review209666

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fba5a40806a6
Fix some warnings which hit (almost) always in EditorDOMPointBase r=m_kato

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fba5a40806a6