Closed Bug 1421888 Opened 4 years ago Closed 4 years ago

highlight-painted-layers affects masks

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

(Whiteboard: [wr-reserve])

Attachments

(1 file)

I noticed that the tab text overflow fade effect looked wrong (cut off) when I had the highlight-painted-layers pref set. Then I realized that we were applying the highlight fill to the mask itself, which isn't really helping anybody.
Comment on attachment 8933179 [details]
Bug 1421888 - Don't apply highlight-painted-layers or paint-flashing fills when drawing mask surfaces.

https://reviewboard.mozilla.org/r/204134/#review209650
Attachment #8933179 - Flags: review?(ethlin) → review+
Priority: -- → P1
Whiteboard: [wr-reserve]
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/9369c3cededf
Don't apply highlight-painted-layers or paint-flashing fills when drawing mask surfaces. r=ethlin
https://hg.mozilla.org/mozilla-central/rev/9369c3cededf
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.