"Synced Tabs" sidebar's laptop image looks bad with Windows's light gray background color

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: cpeterson, Assigned: eoger)

Tracking

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox57 unaffected, firefox58 unaffected, firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

2 months ago
Created attachment 8933229 [details]
Synced_Tabs_sidebar_Windows.png

STR:
1. Using Firefox Nightly 59 on Windows 10, open the Synced Tab sidebar (in a new user profile that is not logged into Sync): View menu > Sidebar menu > Synced Tabs.
2. Examine the outline of the Synced Tabs sidebar's laptop image.

RESULT:
On Windows, the Synced Tabs sidebar's background color is light gray, which causes the laptop image's dark gray cloud outlines to look like unintentional rendering artifacts. See the attached screenshots.

This laptop image is new in Nightly 59.
(Reporter)

Comment 1

2 months ago
Created attachment 8933230 [details]
Synced_Tabs_sidebar_Mac.png

On macOS, the Synced Tabs sidebar's background color is dark gray so the dark gray cloud outlines do not look bad.

Updated

2 months ago
Flags: needinfo?(rfeeley)
Pixel sampled in Photoshop (and tested in my own Windows 8 install) the Windows sidebar background is actually pure white (#FFFFFF).

Is this a bug?

I thought it was supposed to be light grey on every desktop OS?
Flags: needinfo?(rfeeley) → needinfo?(cpeterson)
(Reporter)

Comment 3

2 months ago
(In reply to Ryan Feeley [:rfeeley] from comment #2)
> Pixel sampled in Photoshop (and tested in my own Windows 8 install) the
> Windows sidebar background is actually pure white (#FFFFFF).
> 
> Is this a bug?
> 
> I thought it was supposed to be light grey on every desktop OS?

I don't know what the intended design. I see the same sidebar color in Firefox 57, Beta 58, and Nightly 59. On my Mac, the background is gray (as shown in screenshot attachment 8933230 [details]). On my Windows 10 laptop, the background is white (as shown in screenshot attachment 8933229 [details]).

I called my Windows sidebar color "light gray" above, but now that I look more closely, it really is pure white. My screen was just dim. :)
Flags: needinfo?(cpeterson)
Created attachment 8933779 [details]
sync-illustrations.zip

Good find. Here are the two version (full heart and broken heart) to be simultaneously background and grey compatible. Look good eoger?
Flags: needinfo?(eoger)
(Assignee)

Comment 5

a month ago
It looks like the 2 provided illustrations are the same (broken heart in both images). Can you provide new ones Ryan?
Flags: needinfo?(eoger) → needinfo?(rfeeley)
Created attachment 8937489 [details]
sync-illustrations.zip

Oops! Now there are two bugs.
Attachment #8933779 - Attachment is obsolete: true
Flags: needinfo?(rfeeley)
I mean two hearts (one broken, one not). I will stop typing when people are talking to me.
(Assignee)

Updated

a month ago
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)

Comment 9

a month ago
mozreview-review
Comment on attachment 8937512 [details]
Bug 1421937 - Update sync-illustration svgs.

https://reviewboard.mozilla.org/r/208198/#review214048

rs=me if rfeeley approves (which I assume he did as he supplied them :)
Attachment #8937512 - Flags: review?(markh) → review+

Comment 10

a month ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/375663a2b771
Update sync-illustration svgs. r=markh

Comment 11

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/375663a2b771
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.