Steps: 1) Launch Editor by choosing Editor option in Task menu 2) Click on anywhere on the bold "html" text and notice change in Bold icon state 3) Double click on text "testing" to select the whole word and notice the Bold icon is not active 4) Click the Bold icon once and notice that the text "testing" is not bold 5) Move the mouse away from the Bold icon and notice that the state says that the selected "testing" text is not bold even though it is 6) Undo the selection on the text "testing" by clicking on the text to place cursor some where in side the word and notice that the Bold icon says that the text is not bold when it is Actual Results: Bold icon does not reflect actual text property Expected: Bold icon states should change when bolding is applied or removed Build 1999091608 on NT
sounds like bold is working correctly, but the button is not reflecting that fact. Could it be that the selection is outside the boundary of the bold, and we have to be smarter when we query for the property? <P> T0 <B> T2 'a' T1 'c' 'b' in this simple content model, we can represent a selection of "b" by Sel((T1,0), (T1,1)) or Sel((T0,1), (T2,0)) we should report either as bold from nsIHTMLEditor::GetInlineProperty(). Maybe nsHTMLEditor::GetInlineProperty() has to be smart enough to account for selection at the boundaries and treat the selection as the tightest legal selection that encompasses the same content? OR, is the button code just wrong?
No, I think this is a problem with widgets. On Mac, the bold button works correctly. On Unix and Windows, it does not. I have no idea what could cause this difference in behaviour, but it is reliable. I'll take a look.
I notice that now the text attribute state is set correctly (in Windows) when there is a selection, but not if you simply click (collapsed selectio/caret) in some text that has a particular attribute.
on win95 using build 1999111108, I still see this problem. If I select within a formatted area (B|I|U) the format toolbar does not indicate the correct state. And the other issues that bijal mentions are still there.
moving to m14
the bug charlie mentions (bad inline style feedback with collapsed selection) is cross-platform, and I know what's wrong there. I've broken this out as a seperate bug: 24574, assigned to me.
far as we can tell, things pretty much work except icon state does not reflect change....seems ok for beta1
This works now.
verified in 2/28 build.