Remove B2G related tests in dom/events/test/marionette/

NEW
Unassigned

Status

()

Core
DOM: Events
P2
normal
2 months ago
2 months ago

People

(Reporter: ahal, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 months ago
+++ This bug was initially created as a clone of Bug #1422006 +++

Running |mach test marionette| results in:
Exception: Test file names must be of the form 'test_something.py'. Invalid test names:
  /home/ahal/hg/mozilla-central/dom/events/test/marionette/test_sensor_orientation.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_add_interface.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_connect_with_dhcp.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_connect_with_static_ip.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_disable.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_disconnect.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_enable.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_ip_mode_change.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_reconnect_with_dhcp.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_reconnect_with_static_ip.js
  /home/ahal/hg/mozilla-central/dom/network/tests/marionette/test_ethernet_remove_interface.js

  File "/home/ahal/hg/mozilla-central/testing/mach_commands.py", line 128, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "/home/ahal/hg/mozilla-central/testing/marionette/mach_commands.py", line 93, in run_marionette_test
    return run_marionette(tests, topsrcdir=self.topsrcdir, **kwargs)
  File "/home/ahal/hg/mozilla-central/testing/marionette/mach_commands.py", line 63, in run_marionette
    failed = MarionetteHarness(MarionetteTestRunner, args=vars(args)).run()
  File "/home/ahal/hg/mozilla-central/testing/marionette/harness/marionette_harness/runtests.py", line 72, in run
    runner.run_tests(tests)
  File "/home/ahal/hg/mozilla-central/testing/marionette/harness/marionette_harness/runner/base.py", line 850, in run_tests
    self._add_tests(tests)
  File "/home/ahal/hg/mozilla-central/testing/marionette/harness/marionette_harness/runner/base.py", line 801, in _add_tests
    " Invalid test names:\n  {}".format('\n  '.join(invalid_tests)))

We should fix this and make sure marionette tests also get picked up when specifying a path.
Those are js files which were most likely related to B2G. Marionette does not have a JS runner anymore. So how are those tests been run? Is there a Python test module as entry point?
Flags: needinfo?(ahalberstadt)
(Reporter)

Comment 2

2 months ago
Looks like |mach test| is dispatching to |mach marionette-test|. I'm not really sure why this is happening, maybe the correct fix is to remove those tests? Maybe the test resolving logic needs to be updated?

Ftr, I'm filing all the issues I can find with |mach test| and haven't looked into this particular one in much detail.
Flags: needinfo?(ahalberstadt)
I checked and those are indeed B2G tests. The DOM team should care about removing those tests.
Component: Marionette → DOM: Events
Product: Testing → Core
Summary: Error running |mach test marionette| → Remove B2G related tests in dom/events/test/marionette/

Updated

2 months ago
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.