1422033 - window.open throws NS_ERROR_FAILURE when opener has no features and no other window with features is opened

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[abahcecioglu]

Attachment: pages.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce:

I've got 3 pages. In the first page there is a Button to open the second page with the following javascript command:

window.open("./page2.html", "page2", "menubar=no, status=no, toolbar=no, location=no, resizable=yes");

So in the second page there are 3 buttons. The first button listens to the following click callback:

window.open("./page3.html", "page3", "menubar=no, status=no, toolbar=no, location=no, resizable=yes");

The second button listens to:

window.open("./page3.html", "page3", "menubar=yes, status=yes, toolbar=yes, location=yes, resizable=yes");

And the third button listens to:

window.open("./page3.html", "page3", "");


Actual results:

All 3 window.open calls works fine until the window with page1 is still open.

The third butten opens the new window as a new tab in the same browser window where page1 is opened. 

If i click the third button, while there is no other browser window opened with the toolbar aktive, the window.open function throws a NS_ERROR_FAILURE.


Expected results:

The window.open call with an empty string as feature parameter should open a new browser window without throwing a NS_ERROR_FAILURE.

Comment 1

[Andrew Overholt [:overholt]]

Nika has done some docshell work so may have an idea if we're spec-compliant here.

Comment 2

[Andrew Overholt [:overholt]]

Maybe this is e10s-related, too, like bug 1422603 is?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

This is technically spec compliant, because there's a nice "catch-all" case in the spec saying that a user agent can always refuse to open a window ^.^ (https://html.spec.whatwg.org/#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name)

    If the user agent has been configured such that in this instance it will not find a browsing context
        Do nothing.

That being said, this isn't great behaviour. We should do better. I've got some idea of why this doesn't work. I'll look into fixing it.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Chrome's behaviour here is to open a new normal browsing window, and open the new tab in that window, which I think we should copy.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Support opening a new window when no windows are avaliable for a new tab

This patch unfortunately doesn't come with a test yet, because it's not possible to close the window which you start with in a mochitest-browser without breaking the test harness.

I could probably do it with a Marionette test. Let me know if that would be a good idea.

MozReview-Commit-ID: DzSllBVdUhq

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8934697 [details] [diff] [review]
Support opening a new window when no windows are avaliable for a new tab

r=me, but what about the non-e10s codepath?  Or does that already have this behavior?

Comment 7

[Nika Layzell [:nika] (ni? for response)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #6)
> r=me, but what about the non-e10s codepath?  Or does that already have this
> behavior?

Yes, in my test the non-e10s codepath already handled this correctly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a65ee5a914a9
Support opening a new window when no windows are avaliable for a new tab, r=bz

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a65ee5a914a9