Closed
Bug 1422101
Opened 6 years ago
Closed 6 years ago
Add some sanity-checking bits to function name-resolution code
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
2.11 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Some of the name-resolution algorithm consists of bumping and unbumping an index into an array of pointers in a certain manner. Everything checks out in the logic of it, but it's still a bit fragile. Let's add some sanity-checking assertions and poisoning for peace of mind. arai reviewed this patch elsewhere, so just filing this bug to have a number to tag in the patch, mostly.
Attachment #8933430 -
Flags: review+
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/78e2c8c0404e Add some sanity-checking code to some of the name-resolution manipulation. r=arai in private conversation
Comment 2•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/78e2c8c0404e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•