1422107 - Remove the BIOS_Manufacturer data collection at startup

Status: RESOLVED INACTIVE

(Core :: General, enhancement)

Description

[(Away)]

This code was added to gather data for the AMD support engineers we were talking to, back when we were unsure whether "the AMD bug" was really an AMD bug.

Well, we're pretty sure now, and this code probably doesn't need to stay. Most of the work is off-thread but still it's extra code on the startup path.

Crash/stability/uptime people, any objections?

Comment 1

[[:philipp]]

no objections from my side.

the only time i remember attempting to make use of it was with the 64-bit crashes correlated to lenovo (bug 1369361) - i wanted to do a reverse search, but ran into bug 1369336 anyway :))

Comment 2

[Marco Castelluccio [:marco]]

Can the crash reporter collect this information instead of Firefox itself?

Comment 3

[(Away)]

(In reply to Marco Castelluccio [:marco] from comment #2)
> Can the crash reporter collect this information instead of Firefox itself?

Probably. Two things I'm uncertain about:

1: Do we already have an existing mechanism to merge annotations collected in the crash reporter with those collected in Firefox? If not, implementing it adds an additional cost.

2: Currently we launch a background thread and forget about it. If the annotation happens, great, otherwise we don't know/care. If this were to happen in the crash reporter, I assume we'd want it to be synchronous. I don't know how long this code takes. Perhaps it might add an annoying delay in some long-tail cases.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

no activity for a while, closing