1422171 - When dragging a link into a bookmark folder and scrolling down via the hovering over the down arrow it scrolls way too fast

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P5)

Description

[yt.sini]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171128222554

Steps to reproduce:

1. Drag a link over a bookmark folder, with enough items to make the up and down scroll arrows apear, to open the folder.
2. Hover over the bottom arrow to scroll down.


Actual results:

The view jumped down to the bottom of the folder in a splitsecond.


Expected results:

It should scroll down at normal speed.

Comment 1

[YF (Yang)]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db88d543de14b78333b095485de56cb8e9832af9&tochange=e1c23455946bd42445a0a12d223c7548c39c9785

Comment 2

[Drew Willcoxon :adw]

Is this only a problem for this specific case, or do all menus now scroll way too fast (regardless of whether you're dragging anything)?

Comment 3

[yt.sini]

(In reply to Drew Willcoxon :adw from comment #2)
> Is this only a problem for this specific case, or do all menus now scroll
> way too fast (regardless of whether you're dragging anything)?

Seems to only be happening when dragging links down bookmark folders.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix in 59. We can still take a patch in Nightly.

Comment 5

[Alice0775 White]

And 
If Bookmarks toolbar is overflowed(i.e, chevron is in Bookmarks toolbar),
When dragover "scrollbutton-down" button at bottom, Contents of Bookmarks Toolbar are shifted to the left. 
So, some items of Contents of Bookmarks are unable to access anymore.

:mconley,
Your bunch of patch cause the ui regression, can you please look into this asap?

Comment 6

[Alice0775 White]

Attachment: screencast

no longer able to access the leftmost bookmark on the Bookmarks toolbar :(

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 64. We could still take a patch in 65.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly; if it seems low risk enough please feel free to request uplift to 65 beta.

Comment 10

[oudijzergek]

Scrolling down also does this rappid to the bottom when moving a item allready in the folder from the top downwards

Comment 11

[yt.sini]

The fast scroll seems to be fixed. However now the shifting of the bookmark bar to the left happens multiple times.

Comment 12

[Massimo Fidanza]

The new behaviour reportd by @yt.sini looks ike another bug.

Comment 13

[Alice0775 White]

I cannot reproduce the issue any more on Nightly78.0a1 Windows10 as well as Firefox68.8.0ERSR.