1422198 - Log something from the sandbox file broker if sendmsg()ing the response fails

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P2)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Jed Davis [:jld] (⏰UTC-7) from bug 1420475 comment #4)
> That error message means that the broker closed the request's response
> socket without sending a response.  The interesting thing is that there's no
> accompanying message from the broker (cf., for example, bug 1401774).  This
> is in the middle of a test run, so it's not because of racing with parent
> process shutdown.  So the only case that's left is where sendmsg()ing the
> response fails (and, yes, EINTR is handled).

So let's log something in that case.  Worst case, we'll somtimes get a spurious message about ECONNRESET or ESPIPE or something if the content process exits concurrently with an open(), but those should be easy to distinguish from actual problems (and they aren't something that the test harness will consider a failure).

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1422198 - Log about failure to send a sandbox broker reply.

Review commit: https://reviewboard.mozilla.org/r/206774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206774/

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8935900 [details]
Bug 1422198 - Log about failure to send a sandbox broker reply.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206774/diff/1-2/

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8935900 [details]
Bug 1422198 - Log about failure to send a sandbox broker reply.

https://reviewboard.mozilla.org/r/206774/#review213682

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d857200d4596
Log about failure to send a sandbox broker reply. r=gcp

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d857200d4596