Closed Bug 1422203 Opened 7 years ago Closed 7 years ago

create a source readme instead of a source tarball

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

Attachments

(2 files)

In bug 749312, we were given permission to create a source readme instead of a source tarball. This will save us cycles, disk, and (once this is done) human configuration time.
I'm open about naming. SOURCE is the current filename.
Attachment #8933533 - Flags: review?(rail)
Nice to see this change to reduce some of the resources we're consuming.
Will review and integrate the beetmoverscript PR in my existing PR for the firefox-intree, if that's okay.
Thanks!
Attachment #8933533 - Flags: review?(rail) → review+
Comment on attachment 8933531 [details] [review]
add SOURCE{,.asc} to beetmoverscript templates

LGTM, thank you!
Addressed a tiny comment in the PR.
Attachment #8933531 - Flags: review+
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #4)
> Comment on attachment 8933531 [details] [review]
> add SOURCE{,.asc} to beetmoverscript templates
> 
> LGTM, thank you!
> Addressed a tiny comment in the PR.

Merged and rolled-over into 3.3.0-dev10 on dep beetmover.
All good, except we need to fake a balrog_props.json =\
(In reply to Aki Sasaki [:aki] from comment #6)
> All good, except we need to fake a balrog_props.json =\

I've been thinking of this issue for a while. Because of the balrog_props.json file, beetmover is not as robust and easy-to-use, not even as the old mozharness one used to be. I'm thinking we should brainstorm on this maybe in Austin. If we do this right, I think we might get away with just:
* defining a set of variables that are absolutely needed for any type of beetmover job
* define an optional set of key:value specific for each different type of beetmover job
* if we have balrog_props: get_stuff_from_there() else get from payload.

I'm really hoping this is not as complicated as it sounds and we can get away with more rubstness.

But until then, we can make the source file job be (temporarily) dependent on the Build and get the balrog_props from there.
How's that sound?
Aha! Yeah, depending on the build will work.
Yeah, I added a trello card to get rid of balrog_props.json entirely, and defining those values at graph generation time. Ideally we can pass these values into the build if we need them there (like buildid).
Blocks: 1397773
The beetmover fixes are in bug 1413219.
Marking as fixed on maple.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1432591
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: