1422275 - Favicons do not always appear in tabs upon session restore

Status: RESOLVED DUPLICATE of bug 1401538

(Firefox :: Session Restore, defect, P3)

Description

[u462496]

Often, on session restore, tabs appear but their icons are missing.  When I select the tab and activate it, the icon appears.

This problem is intermittent, though very clearly evident over several updates of mozilla-central over the past several months.  I see it occur in several sessions I have ranging from 150 - 300 tabs.  Unfortunately because it is intermittent I am not able to provide an STR, but I want to get it logged anyway.  I often see it with Bugzilla tabs, though I don't know if there is any connection; I can have 1/2 my Bugzilla tabs show up with icons, and the other half not.  It also happens randomly with other sites as well.  Interestingly, I don't remember ever seeing it happen with a Youtube page.

I will continue observing to see if there is a way to consistently repeat the behavior.

Comment 1

[:Gijs (he/him)]

Do the session states for the tabs that don't have icons have icon URIs defined or not? That is, are the icons missing from the saved-to-disk state, or are the icon URIs there but are they not being loaded?

This also looks vaguely like bug 1401538 (see its dupes for why) and if your sessions are old enough to date back to when that bug was unfixed, perhaps that's the explanation? Would be interesting if you're still seeing issues with more recent tabs/sessions.

Comment 2

[:Gijs (he/him)]

(I'm assuming this is on nightly? Not 100% sure. Either way, this doesn't seem severe enough to block 58 unless this is a recent regression or something.)

Comment 3

[u462496]

(In reply to :Gijs from comment #1)
> Do the session states for the tabs that don't have icons have icon URIs
> defined or not? That is, are the icons missing from the saved-to-disk state,
> or are the icon URIs there but are they not being loaded?
> 
> This also looks vaguely like bug 1401538 (see its dupes for why) and if your
> sessions are old enough to date back to when that bug was unfixed, perhaps
> that's the explanation? Would be interesting if you're still seeing issues
> with more recent tabs/sessions.

I started a fresh working profile 2 days ago and updated to latest Nightly.  So far everything is looking okay and I'm up to 100 tabs now.  I'll keep an eye out and if things look okay we can mark this as resolved.

Comment 4

[u462496]

(In reply to Kevin Jones from comment #3)
> (In reply to :Gijs from comment #1)
> > Do the session states for the tabs that don't have icons have icon URIs
> > defined or not? That is, are the icons missing from the saved-to-disk state,
> > or are the icon URIs there but are they not being loaded?
> > 
> > This also looks vaguely like bug 1401538 (see its dupes for why) and if your
> > sessions are old enough to date back to when that bug was unfixed, perhaps
> > that's the explanation? Would be interesting if you're still seeing issues
> > with more recent tabs/sessions.
> 
> I started a fresh working profile 2 days ago and updated to latest Nightly. 
> So far everything is looking okay and I'm up to 100 tabs now.  I'll keep an
> eye out and if things look okay we can mark this as resolved.

This seems to be okay now.  Marking this as resolved as a duplicate of bug 1401538.  Someone can re-open if the problem appears again.

Comment 5

[kernp25]

This problem still occurs in Firefox 59.0a1 (2017-12-26) (32-Bit).

Comment 6

[:Gijs (he/him)]

(In reply to kernp25 from comment #5)
> This problem still occurs in Firefox 59.0a1 (2017-12-26) (32-Bit).

Please file a separate bug with more details, as Kevin filed this bug and can no longer reproduce, so presumably you're seeing different issues, and we'll need more details in order to investigate what you're seeing.

Comment 7

[kernp25]

https://bugzilla.mozilla.org/show_bug.cgi?id=1427822