WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown

RESOLVED FIXED in Firefox 59

Status

()

Core
DOM: Workers
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: Yoric, Assigned: baku)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown.
I may be wrong, but this looks like an error.
Andrew, can you confirm that this is odd?
Flags: needinfo?(continuation)
I don't know enough about how workers work. Maybe baku can answer your question.
Component: DOM: Web Sockets → DOM: Workers
Flags: needinfo?(continuation) → needinfo?(amarchesini)
(Assignee)

Comment 3

a month ago
Created attachment 8937326 [details] [diff] [review]
gc.patch
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8937326 - Flags: review?(dteller)
Comment on attachment 8937326 [details] [diff] [review]
gc.patch

Review of attachment 8937326 [details] [diff] [review]:
-----------------------------------------------------------------

f=me, but I don't know this piece of code sufficiently to be sure.
Maybe r?bkelly or asuth?
Attachment #8937326 - Flags: review?(dteller) → feedback+
(Assignee)

Updated

a month ago
Attachment #8937326 - Flags: review?(bkelly)

Comment 5

a month ago
Comment on attachment 8937326 [details] [diff] [review]
gc.patch

Review of attachment 8937326 [details] [diff] [review]:
-----------------------------------------------------------------

Can you add an assertion in ~CycleCollectedJSRuntime() that its Shutdown() has been called?  Maybe with #ifdef DEBUG boolean flag or something.
Attachment #8937326 - Flags: review?(bkelly) → review+

Comment 6

a month ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb89831b9aad
WorkerJSRuntime::Shutdown must call the base class ::Shutdown method, f=yoric, r=bkelly

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bb89831b9aad
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.