Closed Bug 1422316 Opened 2 years ago Closed 2 years ago

WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown

Categories

(Core :: DOM: Workers, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Yoric, Assigned: baku)

Details

Attachments

(1 file)

WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown.
I may be wrong, but this looks like an error.
Andrew, can you confirm that this is odd?
Flags: needinfo?(continuation)
I don't know enough about how workers work. Maybe baku can answer your question.
Component: DOM: Web Sockets → DOM: Workers
Flags: needinfo?(continuation) → needinfo?(amarchesini)
Attached patch gc.patchSplinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8937326 - Flags: review?(dteller)
Comment on attachment 8937326 [details] [diff] [review]
gc.patch

Review of attachment 8937326 [details] [diff] [review]:
-----------------------------------------------------------------

f=me, but I don't know this piece of code sufficiently to be sure.
Maybe r?bkelly or asuth?
Attachment #8937326 - Flags: review?(dteller) → feedback+
Attachment #8937326 - Flags: review?(bkelly)
Comment on attachment 8937326 [details] [diff] [review]
gc.patch

Review of attachment 8937326 [details] [diff] [review]:
-----------------------------------------------------------------

Can you add an assertion in ~CycleCollectedJSRuntime() that its Shutdown() has been called?  Maybe with #ifdef DEBUG boolean flag or something.
Attachment #8937326 - Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb89831b9aad
WorkerJSRuntime::Shutdown must call the base class ::Shutdown method, f=yoric, r=bkelly
https://hg.mozilla.org/mozilla-central/rev/bb89831b9aad
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.