Closed
Bug 1422316
Opened 7 years ago
Closed 6 years ago
WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown
Categories
(Core :: DOM: Workers, enhancement)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: Yoric, Assigned: baku)
Details
Attachments
(1 file)
|
779 bytes,
patch
|
bkelly
:
review+
Yoric
:
feedback+
|
Details | Diff | Splinter Review |
WorkerJSRuntime::Shutdown doesn't call parent CycleCollectedJSRuntime::Shutdown. I may be wrong, but this looks like an error.
|
Reporter | |
Comment 1•7 years ago
|
||
Andrew, can you confirm that this is odd?
Flags: needinfo?(continuation)
|
||
Comment 2•7 years ago
|
||
I don't know enough about how workers work. Maybe baku can answer your question.
Component: DOM: Web Sockets → DOM: Workers
Flags: needinfo?(continuation) → needinfo?(amarchesini)
|
Assignee | |
Comment 3•6 years ago
|
||
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8937326 -
Flags: review?(dteller)
|
|
Reporter | |
Comment 4•6 years ago
|
||
Comment on attachment 8937326 [details] [diff] [review] gc.patch Review of attachment 8937326 [details] [diff] [review]: ----------------------------------------------------------------- f=me, but I don't know this piece of code sufficiently to be sure. Maybe r?bkelly or asuth?
Attachment #8937326 -
Flags: review?(dteller) → feedback+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8937326 -
Flags: review?(bkelly)
|
||
Comment 5•6 years ago
|
||
Comment on attachment 8937326 [details] [diff] [review] gc.patch Review of attachment 8937326 [details] [diff] [review]: ----------------------------------------------------------------- Can you add an assertion in ~CycleCollectedJSRuntime() that its Shutdown() has been called? Maybe with #ifdef DEBUG boolean flag or something.
Attachment #8937326 -
Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb89831b9aad WorkerJSRuntime::Shutdown must call the base class ::Shutdown method, f=yoric, r=bkelly
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bb89831b9aad
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•