1422324 - Autophone - Do not issue shutdown intent if the app is not running

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, enhancement)

Description

[Bob Clary [:bc] (inactive)]

stop_application currently automatically issues a shutdown intent regardless of whether the app is running or not. If the app is running, then no harm no foul. However, if the app is *not* running, the intent will cause the app to be started. Since we have not specified a profile, the app will be started with the default profile created under /data/data/<app>/. This defeats our attempts of specifying the profile in order to control the behavior of the app.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1422324-v1.patch

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 8933665 [details] [diff] [review]
bug-1422324-v1.patch

I made a last minute change to remove an intermediate value and left off the trailing :.

:-(

new patch in a moment.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: bug-1422324-v2.patch

That's what I get for making last minute change and not double checking.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8933692 [details] [diff] [review]
bug-1422324-v2.patch

Review of attachment 8933692 [details] [diff] [review]:
-----------------------------------------------------------------

I imagine this is flaky part of the code in different scenarios/configs, but we need to fix what our current problems are now.

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/04aee4e78418093e1a23e16e8dfd351fa7183f19
deploying shortly.