Closed Bug 1422324 Opened 2 years ago Closed 2 years ago

Autophone - Do not issue shutdown intent if the app is not running

Categories

(Testing :: Autophone, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file, 1 obsolete file)

stop_application currently automatically issues a shutdown intent regardless of whether the app is running or not. If the app is running, then no harm no foul. However, if the app is *not* running, the intent will cause the app to be started. Since we have not specified a profile, the app will be started with the default profile created under /data/data/<app>/. This defeats our attempts of specifying the profile in order to control the behavior of the app.
Attached patch bug-1422324-v1.patch (obsolete) — Splinter Review
Attachment #8933665 - Flags: review?(gbrown)
Comment on attachment 8933665 [details] [diff] [review]
bug-1422324-v1.patch

I made a last minute change to remove an intermediate value and left off the trailing :.

:-(

new patch in a moment.
Attachment #8933665 - Attachment is obsolete: true
Attachment #8933665 - Flags: review?(gbrown)
That's what I get for making last minute change and not double checking.
Attachment #8933692 - Flags: review?(gbrown)
Attachment #8933692 - Flags: review?(gbrown) → review?(jmaher)
Comment on attachment 8933692 [details] [diff] [review]
bug-1422324-v2.patch

Review of attachment 8933692 [details] [diff] [review]:
-----------------------------------------------------------------

I imagine this is flaky part of the code in different scenarios/configs, but we need to fix what our current problems are now.
Attachment #8933692 - Flags: review?(jmaher) → review+
https://github.com/mozilla/autophone/commit/04aee4e78418093e1a23e16e8dfd351fa7183f19
deploying shortly.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.