Closed Bug 1422362 Opened 2 years ago Closed 2 years ago

Remove unused parameters from various methods

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

No description provided.
Attached patch bug1422362.patchSplinter Review
Removes no longer used parameters from various functions. (And the unused ZonesIter::atAtomsZone method and the unused JSCompartment::gcIndex field.)
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8933727 - Flags: review?(tcampbell)
Comment on attachment 8933727 [details] [diff] [review]
bug1422362.patch

Review of attachment 8933727 [details] [diff] [review]:
-----------------------------------------------------------------

Yay cleanup!

::: js/src/jit/BaselineCompiler.cpp
@@ +1467,4 @@
>      if (reinit) {
>          if (!callVM(ThrowInitializedThisInfo))
>              return false;
>      } else {

Signatures changed, so jit code change. Good.

::: js/src/jsdtoa.h
@@ +34,5 @@
>   * If se is not nullptr, *se receives a pointer to the character terminating
>   * the scan. If no number can be formed, *se receives a pointer to the first
>   * unparseable character in s00, and zero is returned.
>   *
>   * On overflow, this function returns infinity and does not indicate an error.

Good find
Attachment #8933727 - Flags: review?(tcampbell) → review+
Priority: -- → P1
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ec15b1f9fd3
Remove unused parameters from various methods in js/src. r=tcampbell
Keywords: checkin-needed
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53c688982d4b
Backed out changeset 0ec15b1f9fd3 for linux32 debug bustage in js/src/gc/Cell.h r=backout on a CLOSED TREE
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e39d8a15596a
Remove unused parameters from various methods in js/src. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/e39d8a15596a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.