Remove 'stringbundleset' binding

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P5
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bgrins, Assigned: Kwan)

Tracking

(Blocks 1 bug)

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

(Reporter)

Comment 1

a year ago
From IRC:

> so it is used for layout basically, but not clear to me why we need xul:box ever
> Enn might recall if we have somewhere some special handling for this case

Neil, are you aware of any reason why we have `extends="xul:box"` on a XBL binding?
Flags: needinfo?(enndeakin)

Comment 2

a year ago
For stringbundleset using xul:box wouldn't have any effect.

History from bug 64449 suggests it was just copied from the following stringbundle binding and was just changed to xul:box even though the extends could have been removed.
Flags: needinfo?(enndeakin)

Updated

a year ago
Priority: -- → P5
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED

Comment 4

a year ago
mozreview-review
Comment on attachment 8936595 [details]
Bug 1422374 - Remove pointless stringbudleset binding.

https://reviewboard.mozilla.org/r/207346/#review213884
Attachment #8936595 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 5

a year ago
I'd have struggled to justify a try tun for this on its own, but it got a ride along with bug 1422934:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51f8cb8187054201578d5c92b0a13e18a75aa4bc
Keywords: checkin-needed

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc221281f554
Remove pointless stringbudleset binding. r=enndeakin+6102
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fc221281f554
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.