Closed
Bug 1422374
Opened 8 years ago
Closed 8 years ago
Remove 'stringbundleset' binding
Categories
(Toolkit :: UI Widgets, task, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: bgrins, Assigned: Kwan)
References
Details
(Whiteboard: [xbl-available])
Attachments
(1 file)
There's a binding 'stringbundleset' that does nothing except for extend="xul:box"
- https://dxr.mozilla.org/mozilla-central/search?q=stringbundleset
- https://dxr.mozilla.org/mozilla-central/rev/a21f4e2ce5186e2dc9ee411b07e9348866b4ef30/toolkit/content/widgets/stringbundle.xml#11
- https://dxr.mozilla.org/mozilla-central/rev/a21f4e2ce5186e2dc9ee411b07e9348866b4ef30/toolkit/content/xul.css#971-974
AFAICT this can be removed, although we should keep `visibility: collapse` on the tag in xul.css.
|
Reporter | |
Comment 1•8 years ago
|
||
From IRC:
> so it is used for layout basically, but not clear to me why we need xul:box ever
> Enn might recall if we have somewhere some special handling for this case
Neil, are you aware of any reason why we have `extends="xul:box"` on a XBL binding?
Flags: needinfo?(enndeakin)
|
||
Comment 2•8 years ago
|
||
For stringbundleset using xul:box wouldn't have any effect.
History from bug 64449 suggests it was just copied from the following stringbundle binding and was just changed to xul:box even though the extends could have been removed.
Flags: needinfo?(enndeakin)
|
|
||
Updated•8 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
status-firefox59:
--- → fix-optional
Priority: -- → P5
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936595 [details]
Bug 1422374 - Remove pointless stringbudleset binding.
https://reviewboard.mozilla.org/r/207346/#review213884
Attachment #8936595 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
I'd have struggled to justify a try tun for this on its own, but it got a ride along with bug 1422934:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51f8cb8187054201578d5c92b0a13e18a75aa4bc
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc221281f554
Remove pointless stringbudleset binding. r=enndeakin+6102
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•