Closed Bug 1422374 Opened 3 years ago Closed 3 years ago

Remove 'stringbundleset' binding

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: bgrins, Assigned: Kwan)

References

Details

(Whiteboard: [xbl-available])

Attachments

(1 file)

From IRC:

> so it is used for layout basically, but not clear to me why we need xul:box ever
> Enn might recall if we have somewhere some special handling for this case

Neil, are you aware of any reason why we have `extends="xul:box"` on a XBL binding?
Flags: needinfo?(enndeakin)
For stringbundleset using xul:box wouldn't have any effect.

History from bug 64449 suggests it was just copied from the following stringbundle binding and was just changed to xul:box even though the extends could have been removed.
Flags: needinfo?(enndeakin)
Priority: -- → P5
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Comment on attachment 8936595 [details]
Bug 1422374 - Remove pointless stringbudleset binding.

https://reviewboard.mozilla.org/r/207346/#review213884
Attachment #8936595 - Flags: review?(enndeakin) → review+
I'd have struggled to justify a try tun for this on its own, but it got a ride along with bug 1422934:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51f8cb8187054201578d5c92b0a13e18a75aa4bc
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc221281f554
Remove pointless stringbudleset binding. r=enndeakin+6102
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc221281f554
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.