Closed Bug 1422376 Opened 6 years ago Closed 5 years ago

Buttons displayed in the middle of long release notes in "Recent Updates" tab

Categories

(Toolkit :: Add-ons Manager, defect, P5)

65 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: 08xjcec48, Assigned: soeren.hentzschel, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 1 obsolete file)

Attached image Screenshot.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171128222554

Steps to reproduce:

- Install uBlock Origin (https://addons.mozilla.org/addon/ublock-origin/) or some other extension with long release notes

- Go to about:addons -> Enable "View Recent Updates" -> Recent Updates -> Show Release Notes




Actual results:

The buttons ("Options" "Disable" and "Remove") are moved to the middle of the release notes instead of staying at the top or bottom of them.


Expected results:

The buttons should be at the top or bottom of the release notes.
Severity: normal → minor
Component: Untriaged → Add-ons Manager
Product: Firefox → Toolkit
Priority: -- → P5
Keywords: good-first-bug
Mentor: aswan
Version: 57 Branch → 58 Branch
Hello, My name is Helora Dana and I'm interested in take this bug to help :)
Hi Helora -- go for it! This bug is mentored by aswan and if you need any help, please leave a comment and needinfo him.
Alright! Thank You!
Hello aswan, could you send me the link to the issue repository on Github, please? and I'd be glad if you could show me the steps for running the repository project, so I can get started looking for a solution for that bug.
Hi, first of all thanks for your interest!

I'm not sure I understand your question about Github, bugzilla (which is where we're having this conversation) is where we track Firefox issues.

Building and running Firefox is the first step here.  There are some basic instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

But for this bug you should be able to use artifact builds, which will save significant time:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds

Also, for further questions, please click the button below labeled "Need more information from" and enter my name in the text box, to make sure I see your question.

Good luck, please let me know if you've managed to build and run Firefox and are ready for next steps, or if you get stuck on anything.
Hi, I'm a computer science student and I'm interested in taking on fixing this bug as a "good first bug" if possible.

Regards,
Parham
Flags: needinfo?(aswan)
Hi, feel free to submit a patch and I can help you out. Let me know if you have any other questions.
Mentor: aswan → mstriemer
Flags: needinfo?(aswan)
Version: 58 Branch → 60 Branch
Hi, I'm interested in claiming this bug to work on in my open source development class. How can I go about this?
(In reply to jbembry15 from comment #8)
> Hi, I'm interested in claiming this bug to work on in my open source
> development class. How can I go about this?

Hi there! You might want to take a look at https://wiki.mozilla.org/Add-ons/Contribute/Code for some guidelines on how to get started. You can also ask for help setting up your dev environment by going to irc.mozilla.org, channel #introductions. 

Once you are ready to have a patch reviewed, or if you have any questions, needinfo :mstriemer here and he'll help out. :)
Version: 60 Branch → 61 Branch
Hi,

since there is no activity from jbembry15 since four months and I would like to see this fixed, can I steal this? If yes, should the buttons be on the top or bottom?
Flags: needinfo?(mstriemer)
The buttons should be at the top. These are likely the same buttons as on the regular add-on listing page, so we'll want to make sure those buttons stay where they are.
Flags: needinfo?(mstriemer)
Assignee: nobody → cadeyrn
Seems something is wrong with the integration of my Phabricator request and Bugzilla because Phabricator says "This revision is now accepted and ready to land" but there is no update on Bugzilla. What is the next step?
Flags: needinfo?(mstriemer)
So I tried to fix this in phabricator but it looks like the patch needs to be uploaded again using arc [1] (or moz-phab).

I think you'll want to add the following line to your commit message:

    Differential Revision: https://phabricator.services.mozilla.com/D5379


[1] https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-arcanist
Flags: needinfo?(mstriemer)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Version: 61 Branch → 63 Branch
Version: 63 Branch → 64 Branch
Sorry for the delay. Since there were problems with my previous attempt to get the patch landed via Phabricator I pulled a fresh copy of mozilla-central, made the changes again and submitted a new Phabricator request. I hope it works now.
Sören, you also need to request review for your patches on Phabricator.  I would suggest requesting review from :mstriemer.  I don't know Mark's schedule specifically but be aware that just about everybody who can review these sorts of changes has limited availability during the holidays...

Hey Sören, not sure if you caught aswan's message from a few weeks ago. If you could just request review from :mstriemer in Phabricator, I think we can get this patch moving again.

Flags: needinfo?(soeren.hentzschel)

Sorry, I totally missed the previous message. I requested a review.

Flags: needinfo?(soeren.hentzschel)
Version: 64 Branch → 65 Branch
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5e880064cfe
Buttons should be at top and not in the middle of the release notes r=mstriemer,aswan
Attachment #9007587 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Woohoo! Thanks so much for the patch, Sören! 🎉

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: