Closed Bug 1422393 Opened 2 years ago Closed 2 years ago

Table border-collapse borders are too opaque and overlap in the corners

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla60
Tracking Status
firefox59 --- unaffected
firefox60 --- verified
firefox61 --- verified

People

(Reporter: mstange, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve])

Attachments

(3 files)

Attached file testcase
In this testcase, with WebRender, the borders are too dark and the corners are even more too dark.
Whiteboard: [wr-mvp] [triage]
Whiteboard: [wr-mvp] [triage] → [wr-reserve]
Assignee: nobody → howareyou322
Morris, please help on this.
Assignee: howareyou322 → mtseng
The dark border edge will be fixed by bug 1419065. I'll address dark corner issue in this bug.
The dark corner is because we didn't handle bevel for collapse border. Bug 1393907 will handle this.
This seems fixed now. We should turn the test case into a reftest.
Assignee: mephisto41 → bugmail
Comment on attachment 8946710 [details]
Bug 1422393 - Add reftest.

https://reviewboard.mozilla.org/r/216682/#review222460

::: layout/reftests/bugs/1422393.html:9
(Diff revision 1)
> +<title>Table border-collapse borders are too opaque and overlap in the corners</title>
> +
> +<style>
> +
> +table {
> +  margin: 50px;

Do you know where this 2px difference comes from?
(In reply to Markus Stange [:mstange] from comment #8)
>
> Do you know where this 2px difference comes from?

I poked around using devtools and it seems that with the border-collapse removed, the <table> element's content box is 76x76 but the enclosed <tbody>'s margin box is 72x72. The <table> also has a "border-spacing: 2px" coming from the UA stylesheet, so presumably that's what is causing this discrepancy. I'm not sure why the border-spacing only takes effect in one case and not the other, but I also noticed that in the border-collapse case, the 10px border is split so that 5px is on the <table> element and 5px is on the <td> element. If border-collapse is removed, all 10px is on the <td>. That might be related?
Maybe. Can you add border-spacing: 0; and make both use the same margin value?
Comment on attachment 8946710 [details]
Bug 1422393 - Add reftest.

https://reviewboard.mozilla.org/r/216682/#review222486

Thanks!
Attachment #8946710 - Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/30c24fbfc860
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 59.0a1 (2017-12-01) onWIndows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID  : 20180322152034
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20180321]
I successfully reproduced the issue with Nightly 59.0a1 (2017-12-01) under macOS 10.12, using the link attached in Comment 0.

The bug is not reproducible on Firefox 60.0b9 and latest Nightly 61.0a1 (2018-04-02) under Windows 10 (x64), Ubuntu 16.04 (x64), and macOS 10.12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.