1422403 - Avoid float->integer->float conversion in ToRelativeLayoutRect

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1422403. Avoid float->integer->float conversion in ToRelativeLayoutRect.

RoundedToInt converts to ints but we want floats.

Review commit: https://reviewboard.mozilla.org/r/204710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204710/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8933765 [details]
Bug 1422403. Avoid float->integer->float conversion in ToRelativeLayoutRect.

https://reviewboard.mozilla.org/r/204710/#review210272

Comment 3

[Kartikaya Gupta (email:[e-mail])]

We actually never assign to mOrigin anymore, so we can probably simplify this further by removing the subtraction.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32ded91397e6
Avoid float->integer->float conversion in ToRelativeLayoutRect. r=kats

Comment 5

[Markus Stange [:mstange]]

I filed bug 1422414 on removing mOrigin.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/32ded91397e6