1422518 - Using meta refresh element with a target of "about:blank" no longer results in an empty address bar

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[u607479]

Attachment: blank-refresh.html

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171130160223

Steps to reproduce:

Open a document (such as the attached one) that uses a meta redirect element to redirect to the page about:blank. The attached document should refresh after three seconds.

mozregression bisection log: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3599d43b43adf486ce3a5749329f3015d16daf4c&tochange=229546747cbf04cf71a235275d7c2eb2520a298b

Context: This is currently used in the Blank New Tab add-on ( https://addons.mozilla.org/firefox/addon/blank-new-tab/ ) to allow using about:blank as the new tab page, as opposed to including a "pseudo" blank page. Originally this was done to avoid bug 1372996 ( https://bugzilla.mozilla.org/show_bug.cgi?id=1372996 ), but I've continued to use the redirect even after that bug was fixed as it meant the identity box (with extension name) was not shown, giving a tidier look.


Actual results:

The string "about:blank" remains in the address bar after the refresh, with the address bar focused and the cursor positioned at the end of the string.


Expected results:

The address bar is empty and focused, showing only the placeholder text "Search or enter address".

Comment 1

[u607479]

Sorry, there's a small mistake in both the actual and expected results in my report - ignore the part about the address bar being focused. I originally wrote this regarding a new tab page set by an add-on, but then realised it occurred with a normal document too.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

I already had a fix for it. Will be landing shortly.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Use LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL for meta refresh

Reviewed by Boris in Bug 1414425 comment 49.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5de4c84e38e7cae2a3ee7c4625c325eb7e2603c3

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Boris, I'm going to use this bug to land the LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL change.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5aec4cde6f874921eaa1b0b9d7e9d4c7feabe0
Bug 1422518 - Use LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL for meta refresh r=bz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5aec4cde6f
Use LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL for meta refresh r=bz

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6f5aec4cde6f

Comment 8

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8934362 [details] [diff] [review]
Use LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL for meta refresh

Approval Request Comment
[Feature/Bug causing the regression]: 
bug 1414425
[User impact if declined]:
Pages loaded from a meta redirect will have a different principal than expected.
[Is this code covered by automated tests?]:
Partly, but not this scenario. I will write a unit test.
[Has the fix been verified in Nightly?]:
Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
Yes. Load attached test case. See comment 0
[List of other uplifts needed for the feature/fix]:
none
[Is the change risky?]:
no.
[Why is the change risky/not risky?]:
This is a small change that only makes the meta load not inherit the triggering principal (as before bug 1414425)
[String changes made/needed]:
none.

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8934362 [details] [diff] [review]
Use LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL for meta refresh

Fix a meta redirect regression issue. Beta58+.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/993ed1384ef7

Comment 12

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using Nightly from 2017-12-02 on Windows 10 x64. The string "about:blank" remains in the address bar after the refresh.
I tested on latest Nightly 59 and beta 58.0b10 on Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x32, but the bug is not reproducing anymore.