stylo: ClassOrClassList does extra function calls unnecessarily.

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(2 attachments)

nsAttrValue::Type happens to be an out of line call. It shouldn't.

Also, maybe it should be moved to nsAttrValueInlines?
Comment on attachment 8933933 [details]
Bug 1422524: Avoid calling nsAttrValue::Type twice in the common case.

https://reviewboard.mozilla.org/r/204860/#review210356
Attachment #8933933 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8933932 [details]
Bug 1422524: Inline nsAttrValue::Type.

https://reviewboard.mozilla.org/r/204858/#review210358
Attachment #8933932 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8933932 [details]
Bug 1422524: Inline nsAttrValue::Type.

I forgot the `inline` keyword, and that made a few warnings pop in, which I had not detected because I was using a debug build. This could benefit from another look :)
Attachment #8933932 - Flags: review+ → review?(xidorn+moz)
Comment on attachment 8933932 [details]
Bug 1422524: Inline nsAttrValue::Type.

https://reviewboard.mozilla.org/r/204858/#review210362
Attachment #8933932 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f77500d7262c
Avoid calling nsAttrValue::Type twice in the common case. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/f5921af9f1a6
Inline nsAttrValue::Type. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/f77500d7262c
https://hg.mozilla.org/mozilla-central/rev/f5921af9f1a6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.