Closed Bug 1422541 Opened 3 years ago Closed 3 years ago

Port |Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters| to mailnews

Categories

(MailNews Core :: Backend, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

Bug 1420954 is now on autoland with:
https://hg.mozilla.org/integration/autoland/rev/480c6e1721e9
https://hg.mozilla.org/integration/autoland/rev/8ce0a0d49d9e

It will cause bustage when it merges. We need to port this:
-    NS_FORWARD_SAFE_NSIURISETTERS(mURI)
+    NS_FORWARD_SAFE_NSIURISETTERS_RET(mURI)

and

-    NS_IMETHOD SetSpec(const nsACString & aSpec) override {
+    NS_IMETHOD SetSpec(const nsACString & aSpec, nsIURIMutator** aMutator) override {
+      NS_ADDREF(*aMutator = this);

to

ldap/xpcom/src/nsLDAPURL.h
mailnews/addrbook/src/nsAddbookUrl.h
mailnews/base/util/nsMsgMailNewsUrl.h
mailnews/compose/src/nsSmtpUrl.h
This should do it. Uncompiled and untested.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cc3095993953
port bug 1420954 to mailnews [Make nsIURIMutator setters return nsIURIMutator]. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8933950 [details] [diff] [review]
1422541-mutator.patch

PLR ;-)
Attachment #8933950 - Flags: review?(acelists)
Target Milestone: --- → Thunderbird 59.0
Comment on attachment 8933950 [details] [diff] [review]
1422541-mutator.patch

Review of attachment 8933950 [details] [diff] [review]:
-----------------------------------------------------------------

Good copy :)
Attachment #8933950 - Flags: review?(acelists) → review+
You need to log in before you can comment on or make changes to this bug.