Closed Bug 1422547 Opened 2 years ago Closed 2 years ago

Mock appInfo for xpcshell tests does not define uniqueProcessID

Categories

(Testing :: XPCShell Harness, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

In Thunderbird we have xpcshell tests that test our builtin extension Calendar/Lightning.

When one of these tests fails, we get this error (among others):
JavaScript strict warning: resource://gre/modules/ExtensionUtils.jsm, line 33: ReferenceError: reference to undefined property "uniqueProcessID"
Attached patch 1422547.patchSplinter Review
Attachment #8933960 - Flags: review?(continuation)
Attachment #8933960 - Flags: review?(continuation) → review+
Aryx, I'll need a try run for m-c please.
Flags: needinfo?(aryx.bugmail)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfce18cd4bbf05479e24813cb28ab17c780b9f7f

You can push to M-C try, easily. I used:
  try: -b do -p linux64 -u xpcshell -t none
since that is what Aryx used in bug 1420758. And it makes sense since you want to check the xpcshell tests.

In general, you can use the Try Chooser: https://mozilla-releng.net/trychooser/
But of course it's nice to delegate work ;-)
Flags: needinfo?(aryx.bugmail)
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22fc85cc11a1
Define uniqueProcessID in newAppInfo of testing/modules/AppInfo.jsm as it is accessed in xpcshell tests and ExtensionUtils.jsm. r=mccr8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22fc85cc11a1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.