Closed
Bug 1422648
Opened 7 years ago
Closed 7 years ago
nsSocketTransport::mNetAddrPreResolved is always false. Should be removed
Categories
(Core :: Networking, enhancement, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: valentin, Assigned: bharatraghunthan9767, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged])
Attachments
(1 file)
mNetAddrPreResolved doesn't seem to be used currently. At some point (esr52) it seems FlyWeb was using it, by calling InitPreResolved. That method no longer exists, and mNetAddrPreResolved is always false. We should remove it.
|
Assignee | |
Comment 1•7 years ago
|
||
Should we also remove https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsSocketTransport2.cpp#1074-1077 since that should only work if nsSocketTransport::mNetAddrPreResolved is true?
Flags: needinfo?(valentin.gosu)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8934049 -
Flags: review?(valentin.gosu)
|
Reporter | |
Comment 3•7 years ago
|
||
(In reply to Bharat Raghunathan from comment #1) > Should we also remove [...] Yes. The patch looks great! I'll trigger a try run, then I'll check it in. Good job!
Assignee: nobody → bharatraghunthan9767
Flags: needinfo?(valentin.gosu)
|
|
Reporter | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934049 [details] Bug 1422648 - Removed instances of nsSocketTransport::mNetAddrPreResolved https://reviewboard.mozilla.org/r/204988/#review210592 Try looks good. Pushing to autoland.
Attachment #8934049 -
Flags: review?(valentin.gosu) → review+
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1193ebae055e Removed instances of nsSocketTransport::mNetAddrPreResolved r=valentin
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1193ebae055e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
|
Assignee | |
Comment 7•7 years ago
|
||
Thank you @valentin !!
You need to log in
before you can comment on or make changes to this bug.
Description
•