1422669 - Restore librlz from Bug 1332530 for calculating the machine ID.

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[James Cheng[:JamesCheng]]

In order to implement ``cdm::Host_9::RequestStorageId``, we should provide a device identifier and provide it into CDM.

So I need to restore the ``librlz`` from "Bug 1332530 - Remove GMP device binding"

The patch will be Bug 1060179  + Bug 1214018.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1422669 - Part1 - Restore librlz from Bug 1332530.

Review commit: https://reviewboard.mozilla.org/r/205764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205764/

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1422669 - Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX.

Review commit: https://reviewboard.mozilla.org/r/205766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205766/

Comment 3

[James Cheng[:JamesCheng]]

Attachment: Bug 1422669 - Part3 - Introduce rlz_lib::GetMachineId and its related helper functions.

Chromium uses rlz_lib::GetMachineId as a factor when calculating storage id.

Review commit: https://reviewboard.mozilla.org/r/205818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205818/

Comment 4

[James Cheng[:JamesCheng]]

Attachment: Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation.

The reason explained in patch Part1 of Bug 1214018.

Review commit: https://reviewboard.mozilla.org/r/205820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205820/

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8934838 [details]
Bug 1422669 - Part1 - Restore librlz from Bug 1332530.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205764/diff/1-2/

Comment 6

[James Cheng[:JamesCheng]]

Comment on attachment 8934839 [details]
Bug 1422669 - Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205766/diff/1-2/

Comment 7

[James Cheng[:JamesCheng]]

There was a build error without Part2

https://treeherder.mozilla.org/logviewer.html#?job_id=150078532&repo=try&lineNumber=14917

[task 2017-12-06T04:08:35.298Z] 04:08:35     INFO -  /builds/worker/workspace/build/src/dom/media/gmp/rlz/mac/lib/machine_id_mac.cc:225:55: error: possible misuse of comma operator here [-Werror,-Wcomma]
14918
[task 2017-12-06T04:08:35.298Z] 04:08:35     INFO -             IOIteratorNext(primary_interface_iterator)), primary_interface) {
14919
[task 2017-12-06T04:08:35.298Z] 04:08:35     INFO -                                                        ^
14920
[task 2017-12-06T04:08:35.299Z] 04:08:35     INFO -  /builds/worker/workspace/build/src/dom/media/gmp/rlz/mac/lib/machine_id_mac.cc:224:10: note: cast expression to void to silence warning
14921
[task 2017-12-06T04:08:35.299Z] 04:08:35     INFO -    while (primary_interface.reset(
14922
[task 2017-12-06T04:08:35.300Z] 04:08:35     INFO -           ^~~~~~~~~~~~~~~~~~~~~~~~
14923
[task 2017-12-06T04:08:35.300Z] 04:08:35     INFO -  1 error generated.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8934839 [details]
Bug 1422669 - Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX.

https://reviewboard.mozilla.org/r/205766/#review211604

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8934895 [details]
Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation.

https://reviewboard.mozilla.org/r/205820/#review211606

::: commit-message-e7583:3
(Diff revision 1)
> +Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation.
> +
> +The reason explained in patch Part1 of Bug 1214018.

I'd rather you just copy the reason here, instead of making interested people go find it ;-)

Comment 10

[James Cheng[:JamesCheng]]

Comment on attachment 8934895 [details]
Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205820/diff/1-2/

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8934838 [details]
Bug 1422669 - Part1 - Restore librlz from Bug 1332530.

https://reviewboard.mozilla.org/r/205764/#review213054

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8934894 [details]
Bug 1422669 - Part3 - Introduce rlz_lib::GetMachineId and its related helper functions.

https://reviewboard.mozilla.org/r/205818/#review213056

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f328acece86
Part1 - Restore librlz from Bug 1332530. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/63188c5efa07
Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX. r=gerald
https://hg.mozilla.org/integration/autoland/rev/2f00a8825863
Part3 - Introduce rlz_lib::GetMachineId and its related helper functions. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/062587b837a9
Part4 - Kill string16 and replace with our SHA1 implementation. r=gerald

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7f328acece86
https://hg.mozilla.org/mozilla-central/rev/63188c5efa07
https://hg.mozilla.org/mozilla-central/rev/2f00a8825863
https://hg.mozilla.org/mozilla-central/rev/062587b837a9