Closed
Bug 1422669
Opened 7 years ago
Closed 7 years ago
Restore librlz from Bug 1332530 for calculating the machine ID.
Categories
(Core :: Audio/Video: GMP, enhancement, P3)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
References
Details
Attachments
(4 files)
In order to implement ``cdm::Host_9::RequestStorageId``, we should provide a device identifier and provide it into CDM. So I need to restore the ``librlz`` from "Bug 1332530 - Remove GMP device binding" The patch will be Bug 1060179 + Bug 1214018.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8934838 -
Flags: review?(cpearce)
Attachment #8934839 -
Flags: review?(gsquelart)
Attachment #8934894 -
Flags: review?(cpearce)
Attachment #8934895 -
Flags: review?(gsquelart)
|
|
Assignee | |
Comment 7•7 years ago
|
||
There was a build error without Part2 https://treeherder.mozilla.org/logviewer.html#?job_id=150078532&repo=try&lineNumber=14917 [task 2017-12-06T04:08:35.298Z] 04:08:35 INFO - /builds/worker/workspace/build/src/dom/media/gmp/rlz/mac/lib/machine_id_mac.cc:225:55: error: possible misuse of comma operator here [-Werror,-Wcomma] 14918 [task 2017-12-06T04:08:35.298Z] 04:08:35 INFO - IOIteratorNext(primary_interface_iterator)), primary_interface) { 14919 [task 2017-12-06T04:08:35.298Z] 04:08:35 INFO - ^ 14920 [task 2017-12-06T04:08:35.299Z] 04:08:35 INFO - /builds/worker/workspace/build/src/dom/media/gmp/rlz/mac/lib/machine_id_mac.cc:224:10: note: cast expression to void to silence warning 14921 [task 2017-12-06T04:08:35.299Z] 04:08:35 INFO - while (primary_interface.reset( 14922 [task 2017-12-06T04:08:35.300Z] 04:08:35 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~ 14923 [task 2017-12-06T04:08:35.300Z] 04:08:35 INFO - 1 error generated.
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934839 [details] Bug 1422669 - Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX. https://reviewboard.mozilla.org/r/205766/#review211604
Attachment #8934839 -
Flags: review?(gsquelart) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934895 [details] Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation. https://reviewboard.mozilla.org/r/205820/#review211606 ::: commit-message-e7583:3 (Diff revision 1) > +Bug 1422669 - Part4 - Kill string16 and replace with our SHA1 implementation. > + > +The reason explained in patch Part1 of Bug 1214018. I'd rather you just copy the reason here, instead of making interested people go find it ;-)
Attachment #8934895 -
Flags: review?(gsquelart) → review+
| Comment hidden (mozreview-request) |
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934838 [details] Bug 1422669 - Part1 - Restore librlz from Bug 1332530. https://reviewboard.mozilla.org/r/205764/#review213054
Attachment #8934838 -
Flags: review?(cpearce) → review+
|
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934894 [details] Bug 1422669 - Part3 - Introduce rlz_lib::GetMachineId and its related helper functions. https://reviewboard.mozilla.org/r/205818/#review213056
Attachment #8934894 -
Flags: review?(cpearce) → review+
|
||
Comment 13•7 years ago
|
||
Pushed by jacheng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f328acece86 Part1 - Restore librlz from Bug 1332530. r=cpearce https://hg.mozilla.org/integration/autoland/rev/63188c5efa07 Part2 - Fix compiling error [-Werror,-Wcomma] by Part1 on OSX. r=gerald https://hg.mozilla.org/integration/autoland/rev/2f00a8825863 Part3 - Introduce rlz_lib::GetMachineId and its related helper functions. r=cpearce https://hg.mozilla.org/integration/autoland/rev/062587b837a9 Part4 - Kill string16 and replace with our SHA1 implementation. r=gerald
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f328acece86 https://hg.mozilla.org/mozilla-central/rev/63188c5efa07 https://hg.mozilla.org/mozilla-central/rev/2f00a8825863 https://hg.mozilla.org/mozilla-central/rev/062587b837a9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•