1422680 - simplify aboutReader.css font-size classes using CSS variables

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

The repetitious font-size related classes in aboutReader.css could probably be simplified a bit by using CSS variables.

Comment 1

[lekhikadugtal]

Hi Gijs, I would like to work on this issue.

Comment 2

[:Gijs (he/him)]

(In reply to lekhikadugtal from comment #1)

Hi Gijs, I would like to work on this issue.

Let's get you started on bug 1148052 first.

Comment 3

[Shivam Singhal [ :championshuttler ]]

Hi @Gjis , I would like to work on it , can i take this up?

Thanks

Comment 4

[:Gijs (he/him)]

(In reply to Shivam Singhal [ :championshuttler ] from comment #3)

Hi @Gjis

Pro tip: It always helps to get people's names right. Copy-paste if not sure.

I would like to work on it , can i take this up?

You're assigned to 11 open bugs, some of which have not been touched for weeks or months. Finish more of those first (ask for help if stuck, or if your reviewer is not responsive or something).

Also, considering the breadth of the codebase you've seen so far, consider asking some of the people you've worked with in specific areas you might want to focus on, for harder/bigger projects to tackle, instead of just fixing more mentored bugs in more different areas of the codebase. Mentored bugs are meant to get people started, not really so much for people who have already fixed 20 bugs and are familiar with Mozilla's processes.

Comment 5

[:Gijs (he/him)]

Monika, does this seem like something you'd be OK tackling?

Comment 6

[Monika Maheshwari [:MonikaMaheshwari]]

Yes. Thanks :)

Comment 7

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: simplify aboutReader.css font-size classes using CSS variables

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a9c9368e4902

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/a9c9368e4902276951295263be5f88f00e589346