Closed Bug 1422680 Opened 2 years ago Closed 1 year ago

simplify aboutReader.css font-size classes using CSS variables

Categories

(Toolkit :: Reader Mode, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- wontfix
firefox67 --- fixed

People

(Reporter: heycam, Assigned: MonikaMaheshwari)

References

Details

(Whiteboard: [reader-mode-firefox-integration])

Attachments

(1 file)

The repetitious font-size related classes in aboutReader.css could probably be simplified a bit by using CSS variables.
Priority: -- → P3
Whiteboard: [reader-mode-firefox-integration]

Hi Gijs, I would like to work on this issue.

(In reply to lekhikadugtal from comment #1)

Hi Gijs, I would like to work on this issue.

Let's get you started on bug 1148052 first.

Hi @Gjis , I would like to work on it , can i take this up?

Thanks

(In reply to Shivam Singhal [ :championshuttler ] from comment #3)

Hi @Gjis

Pro tip: It always helps to get people's names right. Copy-paste if not sure.

I would like to work on it , can i take this up?

You're assigned to 11 open bugs, some of which have not been touched for weeks or months. Finish more of those first (ask for help if stuck, or if your reviewer is not responsive or something).

Also, considering the breadth of the codebase you've seen so far, consider asking some of the people you've worked with in specific areas you might want to focus on, for harder/bigger projects to tackle, instead of just fixing more mentored bugs in more different areas of the codebase. Mentored bugs are meant to get people started, not really so much for people who have already fixed 20 bugs and are familiar with Mozilla's processes.

Monika, does this seem like something you'd be OK tackling?

Flags: needinfo?(monikamaheshwari1996)

Yes. Thanks :)

Flags: needinfo?(monikamaheshwari1996)
Assignee: nobody → monikamaheshwari1996
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1534943
You need to log in before you can comment on or make changes to this bug.