Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText)

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

I did an analysis of some globals that the browser window has defined and found various ones that are no longer used.

In utilityOverlay.js, the following no longer used:

goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText

Now that we don't support legacy add-ons, we should tidy these up as they are unused code.
Depends on: 1422721
Looks like I totally meant globalOverlay.js.
Summary: Remove unused functions from utilityOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText) → Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText)
Comment on attachment 8943065 [details]
Bug 1422720 - Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText).

https://reviewboard.mozilla.org/r/213344/#review219274

Thanks for cleaning this up! :-)

::: toolkit/content/globalOverlay.js:103
(Diff revision 1)
> -  var element = document.getElementById(aID);
> -  if (element)
> -    element.setAttribute("tooltiptext", aTooltipText);
> -}
> -
>  Object.defineProperty(this, "NS_ASSERT", {

I think we should remove this too, but it's really a different bug. Filed bug 1431050.
Attachment #8943065 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27eaf846cbb5
Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText). r=florian
https://hg.mozilla.org/mozilla-central/rev/27eaf846cbb5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
That busted TB completely, see bug 1431309. No heads-up from a current and a former TB contributor :-(
And that two working days before a merge.
(In reply to Jorg K (GMT+1) [Very limited availability 18-22 Jan 2018] from comment #6)
> That busted TB completely, see bug 1431309. No heads-up from a current and a
> former TB contributor :-(
> And that two working days before a merge.

Sorry, but I did warn: see bug 1422721, filed 2 months ago, follow-up warning about 2 weeks ago.
Yes, sorry, Richard just pointed that out to me and I was even CC'ed :-(

There's even a suggestion where to move that stuff, utilityOverlay.js, but I'm still wondering what 'top' is. I can try copying it there now.
All fixed in bug 1422721, my sincere apologies for my comment #6, I should have known better.
You need to log in before you can comment on or make changes to this bug.