Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText)

NEW
Assigned to

Status

()

Toolkit
General
a month ago
7 hours ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox59 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
I did an analysis of some globals that the browser window has defined and found various ones that are no longer used.

In utilityOverlay.js, the following no longer used:

goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText

Now that we don't support legacy add-ons, we should tidy these up as they are unused code.
(Assignee)

Updated

a month ago
Depends on: 1422721
(Assignee)

Comment 1

21 hours ago
Looks like I totally meant globalOverlay.js.
Summary: Remove unused functions from utilityOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText) → Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText)
Comment hidden (mozreview-request)

Comment 3

8 hours ago
mozreview-review
Comment on attachment 8943065 [details]
Bug 1422720 - Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText).

https://reviewboard.mozilla.org/r/213344/#review219274

Thanks for cleaning this up! :-)

::: toolkit/content/globalOverlay.js:103
(Diff revision 1)
> -  var element = document.getElementById(aID);
> -  if (element)
> -    element.setAttribute("tooltiptext", aTooltipText);
> -}
> -
>  Object.defineProperty(this, "NS_ASSERT", {

I think we should remove this too, but it's really a different bug. Filed bug 1431050.
Attachment #8943065 - Flags: review?(florian) → review+

Comment 4

7 hours ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27eaf846cbb5
Remove unused functions from globalOverlay.js (goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText). r=florian
You need to log in before you can comment on or make changes to this bug.