1422721 - Move old utilityOverlay.js functions into Thunderbird code

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Mark Banner (:standard8)]

We've discovered that Firefox no longer uses various functions in utilityOverlay.js, and will be removing them in bug 1422720:

goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText

It looks like Thunderbird/SeaMonkey still use these, my guess is that they'd want to be in utilityOverlay.js, but I haven't tested that.

Comment 1

[:aceman]

setTooltipText seems unused, goOnEvent is used once.
Are there any official replacements for the other functions?

Comment 2

[Mark Banner (:standard8)]

I've not looked in history to find out. My suspicion is that there were some larger replacements/rework for how the menus/commands/keys etc are formed & operated. It is likely that they weren't removed due to add-on compatibility constraints.

I think all of the functions could easily be moved directly into Thunderbird without issue as they are fairly generic wrappers. Though you might want to find out what the replacement work was & get that planned in.

Comment 3

[Frank-Rainer Grahl (:frg)]

Looking back as far as mozilla 1.8 it sees they were only ever used in mail and suite. Why do you want them removed now?

Comment 4

[Mark Banner (:standard8)]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> Looking back as far as mozilla 1.8 it sees they were only ever used in mail
> and suite. Why do you want them removed now?

There's a couple of reasons. Firstly it is dead code, extensions can't use it now, and nothing else is using it (for Firefox). Secondly, we have too many globals already on the browser window and we need to start cutting them down to help it be less complex.

Comment 5

[Mark Banner (:standard8)]

I'm likely to pick up bug 1422720 next week.

It looks like Thunderbird's utilityOverlay.js might be a good place to put stuff, though I've not verified if it'll work for everything or not.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1422721-bustage-fix.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=62a4b882e72cdf3c234d4ff0f292c0c99056fea6

See how far we get with this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87da74e0446e
Adopt goSetMenuValue(), goSetAccessKey(), goOnEvent() into mail/base/. rs=bustage-fix

Comment 8

[Jorg K (CEST = GMT+2)]

That did the trick.

Comment 9

[:aceman]

Comment on attachment 8943522 [details] [diff] [review]
1422721-bustage-fix.patch

Review of attachment 8943522 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 10

[:aceman]

Attachment: fix abContactsPanel

Inspecting mozmill logs revealed 
JavaScript error: chrome://messenger/content/addressbook/abResultsPane.js, line 401: ReferenceError: goSetMenuValue is not defined
in mail/test/mozmill/composition/test-send-button.js | test-send-button.js::test_send_enabled_address_contacts_sidebar

It does not make the test fail, but may affect normal usage.

This happens when right-clicking the found cards inside the contacts panel in compose window.
This patch should fix it.

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 8944207 [details] [diff] [review]
fix abContactsPanel

Thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83de7e9299d5
Follow-up: add utilityOverlay.js to abContactsPanel.xul to get goSetMenuValue(). r=jorgk CLOSED TREE DONTBUILD