Closed Bug 1422727 Opened 7 years ago Closed 7 years ago

Remove unused functions from browser.js

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I did an analysis of some globals that the browser window has defined and found various ones that are no longer used.

In browser.js:

delayedOpenWindow
delayedOpenTab
getMarkupDocumentViewer
FillInHTMLTooltip
stylesheetFillPopup
stylesheetSwitchAll
setStyleDisabled

Now that we don't support legacy add-ons, we should tidy these up as they are unused code.
Comment on attachment 8934138 [details]
Bug 1422727 - Removed some unused functions and variables from browser.js.

https://reviewboard.mozilla.org/r/205086/#review210588

Thanks! So much code in this file that we don't even know what's in there anymore...
Attachment #8934138 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78aad89ae19c
Removed some unused functions and variables from browser.js. r=florian
https://hg.mozilla.org/mozilla-central/rev/78aad89ae19c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: