Closed Bug 1422732 Opened 7 years ago Closed 6 years ago

remove some unneeded things from js/src/old-configure.in

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 1 obsolete file)

Surely there are other things hanging around, but these are obvious.
We don't need things intended for Gecko in js/src/.
Attachment #8934150 - Flags: review?(core-build-config-reviews)
Comment on attachment 8934150 [details] [diff] [review]
remove some unneeded things from js/src/old-configure.in

Review of attachment 8934150 [details] [diff] [review]:
-----------------------------------------------------------------

The MOZ_DEV_EDITION bit was added quite recently (in bug 1396156). I guess we end up #include'ing headers that set defines based on this that aren't themselves under js/src. Something along those lines. 

Has something changed since then to make this alright to remove?
Attachment #8934150 - Flags: review?(core-build-config-reviews)
Bleh, that's unfortunate.  OK, I will remove the MOZ_DEV_EDITION bit.  Ideally the layout stuff can go, though!
Now with just removing the reflow-related bits.
Attachment #8942203 - Flags: review?(cmanchester)
Attachment #8934150 - Attachment is obsolete: true
Attachment #8942203 - Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f63842f2fce7
remove some unneeded things from js/src/old-configure.in; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/f63842f2fce7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: