Closed
Bug 1422732
Opened 7 years ago
Closed 6 years ago
remove some unneeded things from js/src/old-configure.in
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file, 1 obsolete file)
997 bytes,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
Surely there are other things hanging around, but these are obvious.
Assignee | ||
Comment 1•7 years ago
|
||
We don't need things intended for Gecko in js/src/.
Attachment #8934150 -
Flags: review?(core-build-config-reviews)
Comment 2•7 years ago
|
||
Comment on attachment 8934150 [details] [diff] [review] remove some unneeded things from js/src/old-configure.in Review of attachment 8934150 [details] [diff] [review]: ----------------------------------------------------------------- The MOZ_DEV_EDITION bit was added quite recently (in bug 1396156). I guess we end up #include'ing headers that set defines based on this that aren't themselves under js/src. Something along those lines. Has something changed since then to make this alright to remove?
Attachment #8934150 -
Flags: review?(core-build-config-reviews)
Assignee | ||
Comment 3•6 years ago
|
||
Bleh, that's unfortunate. OK, I will remove the MOZ_DEV_EDITION bit. Ideally the layout stuff can go, though!
Assignee | ||
Comment 4•6 years ago
|
||
Now with just removing the reflow-related bits.
Attachment #8942203 -
Flags: review?(cmanchester)
Assignee | ||
Updated•6 years ago
|
Attachment #8934150 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #8942203 -
Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f63842f2fce7 remove some unneeded things from js/src/old-configure.in; r=chmanchester
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f63842f2fce7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•