142277 - Confusing Cookie Confirm window buttons

Status: RESOLVED DUPLICATE of bug 163350

(Core :: Networking: Cookies, enhancement)

Description

[Peter Weilbacher]

The window asking for confirmation of cookies (titled "Confirm") has confusing
buttons. It reads 

The site www.blabla.com wants to set a cookie. Do you want to allow it?
[ ] Remember this decision
[ Yes ]   [ No ]

The Yes/No buttons can easily be regarded as answer to the Remember... question.
I would suggest either renaming these buttons to [Accept cookie] [Deny cookie],
or create new buttons, e.g. [Accept forever][Accept once][Deny once][Deny
forever], thereby replacing the "Remember this decision" checkbox.

Comment 1

[Kai Lahmann (is there, where MNG is)]

sound's resonable.

Comment 2

[Peter Weilbacher]

Is this so difficult to add? After the upgrade from 1.1 to 1.2beta this window
is changed anyway, and wider so that there is enough space. Could you not just
change the names of the buttons from [YES] [NO] to [ACCEPT] [DENY]?

Comment 3

[Peter Weilbacher]

OK, I found the responsible file 

   mozilla/extensions/cookie/resources/locale/en-US/cookieAcceptDialog.dtd

and created the trivial patch below. "button.yes/no.label" are not used anywhere
else in the source, so the change should be safe, and even with the longer text
the buttons fit nicely into the dialog.

Can someone please point me to a page where it is explained what to do to get
this into Mozilla? (And how to do a real patch?)
      
--- cookieAcceptDialog.dtd.orig Fri Oct 18 19:40:11 2002
+++ cookieAcceptDialog.dtd      Fri Oct 18 19:40:33 2002
@@ -8,7 +8,7 @@
 <!ENTITY     props.policy.label             "Policy:">

 <!ENTITY     button.rememberdecision.label  "Remember this decision">
-<!ENTITY     button.yes.label               "Yes">
-<!ENTITY     button.no.label                "No">
+<!ENTITY     button.yes.label               "Accept cookie">
+<!ENTITY     button.no.label                "Deny cookie">

 <!ENTITY     dialog.title                   "Confirm">

Comment 4

[Jonas Maebe]

Additionally, I would definitely switch the YES and NO buttons: the left button
should be NO and the right one YES, like in all "normal" dialogs. I've already
clicked on the wrong button several times because of this interface inconsistency.

Comment 5

[timeless]

uid is being phased out.

Comment 6

[Peter Weilbacher]

Can this not be changed sooner than "Future". For someone who knows how to put
this into the branch/trunk it should take just as much time as changing "Target
Milestone" from "---" to "Future". And I am running the patch from #3 since I
posted it here without problems.

Jonas: What dialog has No on the left and Yes on the right? I only see OK on the
left and Cancel on the right, as e.g. the Preferences dialog. Find dialog is
similar.

Comment 7

[Jonas Maebe]

Seems like I did the "make sure there isn't already a bug about the problem you
want to report" a bit too hastily. I was not talking about Mozilla for Linux,
but about Chimera (lightweight Mozilla-based browser for Mac OS X) :) Sorry for
the noise.

Comment 8

[Christian Reis]

Michiel is solving this as part of bug 163350, and there's already some work
done on it.

*** This bug has been marked as a duplicate of 163350 ***