59 bytes, text/x-review-board-request
I fixed a shutdown delay in bug 1420594. This seems to have caused test_ext_contentScripts_register.js to start failing. I'm disabling for now since we really need to correct the shutdown delay to avoid more leaks, errors being added.
AFAICT this test was added while the shutdown delay was in place and probably just doesn't handle shutdown correctly.
Luca, can you investigate why this fails when shutdown is not delayed? I see some other tests in this directory are disabled on android debug. Is this just similar to those reasons?
(In reply to Ben Kelly [:bkelly] from comment #2) > Luca, can you investigate why this fails when shutdown is not delayed? Yes, absolutely, I'm looking into it. (and I think that it is likely to be related to the "unregistering of programmatically registered content script when the extension is shutting down", which we could and we should avoid if the extension is shutting down because the entire browser is exiting). > I see some other tests in this directory are disabled on android debug. Is > this just similar to those reasons? The reasons behind the WebExtensions tests that are currently disabled only on android debug are usually related to the fact that the arm emulator is pretty slow and it is even slower when we are running on a debug build, and so these tests have an higher rate of failures on android debug (on the contrary the tests that are disabled on all the android targets are usually related to unimplemented APIs on Android, and in lower number of cases because of a testing strategy that works on Desktop but not on Android).
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
The push to try with the patches from Bug 1423913: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=45cc3a1d7424161fa2054b6d357f64e96b0d2637 it doesn't trigger the xpcshell-test crash anymore on this test file. I'm adding Bug 1423913 as a blocker for this bug.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1477688
You need to log in before you can comment on or make changes to this bug.