Closed Bug 1422843 Opened 7 years ago Closed 6 years ago

Silence false positive ABI warnings in NSS 3.35

Categories

(NSS :: Libraries, enhancement)

Product:
NSS
Component:
Libraries
Version:
3.34
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(2 files)

1422843-a.patch
956 bytes, patch
franziskus
: review+
KaiE
: checked-in+
Details | Diff | Splinter Review
1422843-b.patch
1.73 KB, patch
franziskus
: review+
KaiE
: checked-in+
Details | Diff | Splinter Review 
Our ABI checks can report changes that aren't really ABI breakage.
Let's use this bug to track the commits required to silence the false positive warnings.
Assignee: nobody → kaie
Attached patch 1422843-a.patch — — Splinter Review 

        Attachment #8934186 -
        Flags: review?(franziskuskiefer)

        Attachment #8934186 -
        Flags: review?(franziskuskiefer) → review+

    
    

    
  
https://hg.mozilla.org/projects/nss/rev/f8536fe0e128

I'll keep the bug open. There might be more commits necessary during the 3.35 development period.

    
  
Target Milestone: --- → 3.35

    
    

    
  

      
      
      
      

        Attached patch
          
          
        1422843-b.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8942184 -
        Flags: review?(franziskuskiefer)

    
  
Summary: Silence false positive warnings about ABI changes in NSS 3.35 → Silence false positive ABI warnings in NSS 3.35

        Attachment #8942184 -
        Flags: review?(franziskuskiefer) → review+

    
  

        Attachment #8934186 -
        Flags: checked-in+

    
    

    
  
Patch -b used an incorrect function signature. It was created by an older abidiff version 1.0-RC6, which apparently contained a bug.

Because the NSS 3.35 release is completed, let's fix this in bug 1432460 that tracks NSS 3.36
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: