1422848 - NSS taskcluster should run at least one "make optimized" build

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Kai Engert [:KaiE:]]

Currently, taskcluster runs "make" builds only in debug mode, apparently.

It would be good to test optimized make builds, too.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: 1422848-v1.patch

Comment 2

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8934190 [details] [diff] [review]
1422848-v1.patch

Review of attachment 8934190 [details] [diff] [review]:
-----------------------------------------------------------------

::: automation/taskcluster/graph/src/extend.js
@@ +213,5 @@
>      collection: "make",
>      env: {USE_64: "1"}
>    }, "build.sh");
>  
> +  await scheduleWindows("Windows 2012 64 (opt, make)", {

I'd like to avoid adding too many platforms. I don't think that we need Windows opt make builds. The number of Windows NSS users is rather limited.

Comment 3

[Kai Engert [:KaiE:]]

That's fine with me.

I'd also be OK with adding Linux 64bit optimized, only. My primary motiviation is to be able to detect failures in that build configuration, so one architecture should be sufficient.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: 1422848-v2.patch

Comment 5

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8934264 [details] [diff] [review]
1422848-v2.patch

Review of attachment 8934264 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/e3c27c38cb10