Closed
Bug 1422852
Opened 3 years ago
Closed 3 years ago
remove D_INO setting from configure
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
3.48 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
We only had this "for flexibility with other platforms", but given that we set it to the same thing for all platforms, and nobody has tried to change that, this flexibility isn't actually needed.
![]() |
Assignee | |
Comment 1•3 years ago
|
||
Attachment #8934192 -
Flags: review?(core-build-config-reviews)
Comment 2•3 years ago
|
||
Comment on attachment 8934192 [details] [diff] [review] remove D_INO setting from configure Review of attachment 8934192 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/old-configure.in @@ -412,5 @@ > AR_EXTRACT='$(AR) x' > AS='$(CC)' > AS_DASH_C_FLAG='-c' > -DIRENT_INO=d_ino > -MOZ_USER_DIR=".mozilla" Stray deletion of `MOZ_USER_DIR`? Although I guess it's not even used here. Can this go in a separate patch?
Attachment #8934192 -
Flags: review?(core-build-config-reviews) → review+
![]() |
Assignee | |
Comment 3•3 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #2) > ::: js/src/old-configure.in > @@ -412,5 @@ > > AR_EXTRACT='$(AR) x' > > AS='$(CC)' > > AS_DASH_C_FLAG='-c' > > -DIRENT_INO=d_ino > > -MOZ_USER_DIR=".mozilla" > > Stray deletion of `MOZ_USER_DIR`? Although I guess it's not even used here. > Can this go in a separate patch? Whoops! Sorry about that, will remove that bit from the actual commit.
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb8056c40585 remove D_INO setting from configure; r=chmanchester
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb8056c40585
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•