Closed Bug 1422859 Opened 2 years ago Closed 2 years ago

move MOZILLA_*VERSION setting into moz.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

This has the virtue of not executing python three times during configure
just to read the same value of milestone.txt and munge it.  We can also
remove milestone.py as a happy side effect, so all the milestone
computations can be done in init.configure.
The removing of MOZILLA_VERSION reading from js/src/ can wait for another day,
I think.  The only notable change from this set of patches is that
MOZILLA_VERSION* are now represented as byte strings in config.status, but I
think that's OK?

It looks like {extensions,embedding/ios}/confvars.sh references
MOZILLA_VERSION; I think this use case is taken care of by the old-configure
assignments?
Attachment #8934196 - Flags: review?(core-build-config-reviews)
Comment on attachment 8934196 [details] [diff] [review]
move MOZILLA_*VERSION setting into moz.configure

Review of attachment 8934196 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, looks good.
Attachment #8934196 - Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbe0c741aa32
move MOZILLA_*VERSION setting into moz.configure; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/dbe0c741aa32
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.