Closed
Bug 1422873
Opened 8 years ago
Closed 8 years ago
Add full commit message to lando-api GET /revisions endpoint [API]
Categories
(Conduit :: General, enhancement)
Conduit
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zalun, Unassigned)
References
()
Details
Attachments
(1 file)
There is a soft block for this work on getting https://phabricator.services.mozilla.com/D273 and https://phabricator.services.mozilla.com/D275 to land first since those are highly coupled with this card.
# Overview
We won't be initially allowing users to directly edit the commit message in lando-ui and also we should provide the fully formatted summary of the commit message in the api response as well so that the UI and other future clients do not need to know how to construct it (since we do things like append the revision URL).
With this we should rename the lando-api `commit_message_preview` field to `commit_message_title` and add a `commit_message_summary` fields as well. Or we might decide to just have 1 `commit_message` field that contains everything.
Comment 1•8 years ago
|
||
Comment on attachment 8934446 [details]
Revisions API: Full commit message in revisions endpoint
Israel Madueme [:imadueme] has approved the revision.
https://phabricator.services.mozilla.com/D320#7914
Attachment #8934446 -
Flags: review+
Comment 2•8 years ago
|
||
Comment on attachment 8934446 [details]
Revisions API: Full commit message in revisions endpoint
David Walsh :davidwalsh has approved the revision.
https://phabricator.services.mozilla.com/D320#8381
Attachment #8934446 -
Flags: review+
Comment 3•8 years ago
|
||
Comment on attachment 8934446 [details]
Revisions API: Full commit message in revisions endpoint
Steven MacLeod [:smacleod] has approved the revision.
https://phabricator.services.mozilla.com/D320#8389
Attachment #8934446 -
Flags: review+
| Reporter | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•