Closed Bug 1422904 Opened 2 years ago Closed 2 years ago

add an integration test for an add-on signed with sha256

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We have test coverage for PKCS#7/SHA-256 signed package verification in PSM, but we should have an integration test in toolkit.
What is PSM?
Component: WebExtensions: General → Add-ons Manager
It's been called "Personal Security Manager" and "Privacy and Security Module" at various times, but it's basically the security glue layer between gecko and NSS: https://wiki.mozilla.org/Modules/All#Security_-_Mozilla_PSM_Glue . In this case it's the part that implements the signed package verification.
Comment on attachment 8934240 [details]
bug 1422904 - add an integration test for an add-on signed with PKCS#7/SHA-256

https://reviewboard.mozilla.org/r/205160/#review211114
Attachment #8934240 - Flags: review?(dtownsend) → review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2209774a6e59
add an integration test for an add-on signed with PKCS#7/SHA-256 r=mossop
https://hg.mozilla.org/mozilla-central/rev/2209774a6e59
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(dkeeler)
No manual testing required for this change - it just adds an automated test.
Flags: needinfo?(dkeeler) → qe-verify-
See Also: → 1509093
You need to log in before you can comment on or make changes to this bug.