Closed
Bug 1422987
Opened 7 years ago
Closed 6 years ago
Fix override mismatch in getContributingSources work
Categories
(Core :: WebRTC, defect, P1)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
People
(Reporter: ng, Assigned: ng)
References
Details
Attachments
(1 file)
No description provided.| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8934317 -
Flags: review?(jib)
|
|
Assignee | |
Comment 2•7 years ago
|
||
There is a missing const in virtual base of GetRtpSources in MediaConduitInterface, which produces a warning in the TB build, causing the build to fail.
|
||
Comment 3•7 years ago
|
||
Thanks, that fixes my local build. Once reviewed, please ping a sheriff to land it straight onto M-C.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8934317 -
Flags: review?(jib) → review?(mfroman)
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934317 [details] Bug 1422987 - correct override warning in RtpSourceObserver work https://reviewboard.mozilla.org/r/205240/#review210812 Looks good to me.
Attachment #8934317 -
Flags: review?(mfroman) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/mozilla-central/rev/e19b017880c8 Correct override warning in RtpSourceObserver work. r=mjf, a=RyanVM
|
|
||
Comment 6•7 years ago
|
||
It occurred to me that this most likely only affected Windows compiles done with VS2015, like TB's 32bit compiles. It's good that it's fixed since there are a few Mozilla folks still on VS2015 who complain when their local builds are busted.
|
||
Updated•7 years ago
|
|
||
Updated•7 years ago
|
Rank: 9
Priority: -- → P1
|
|
||
Comment 7•6 years ago
|
||
Per comment 5.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•