Miscellaneous changes, mostly logalloc-related

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(10 attachments)

59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
59 bytes, text/x-review-board-request
njn
: review+
Details
Assignee

Description

2 years ago
No description provided.
Assignee

Updated

2 years ago
Assignee: nobody → mh+mozilla
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8934328 [details]
Bug 1423000 - Remove Replay::Commit.

https://reviewboard.mozilla.org/r/205256/#review210846
Attachment #8934328 - Flags: review?(n.nethercote) → review+

Comment 12

2 years ago
mozreview-review
Comment on attachment 8934329 [details]
Bug 1423000 - Count jemalloc_stats as an operation.

https://reviewboard.mozilla.org/r/205258/#review210850
Attachment #8934329 - Flags: review?(n.nethercote) → review+

Comment 13

2 years ago
mozreview-review
Comment on attachment 8934330 [details]
Bug 1423000 - Move MemSlot lookup for replay results into the Replay methods.

https://reviewboard.mozilla.org/r/205260/#review210852
Attachment #8934330 - Flags: review?(n.nethercote) → review+

Comment 14

2 years ago
mozreview-review
Comment on attachment 8934331 [details]
Bug 1423000 - Reject some more invalid logalloc replay logs.

https://reviewboard.mozilla.org/r/205262/#review210854
Attachment #8934331 - Flags: review?(n.nethercote) → review+

Comment 15

2 years ago
mozreview-review
Comment on attachment 8934332 [details]
Bug 1423000 - Move mozjemalloc mutexes to a separate header.

https://reviewboard.mozilla.org/r/205264/#review210856
Attachment #8934332 - Flags: review?(n.nethercote) → review+

Comment 16

2 years ago
mozreview-review
Comment on attachment 8934333 [details]
Bug 1423000 - Use mozjemalloc mutexes in logalloc.

https://reviewboard.mozilla.org/r/205266/#review210858
Attachment #8934333 - Flags: review?(n.nethercote) → review+

Comment 17

2 years ago
mozreview-review
Comment on attachment 8934334 [details]
Bug 1423000 - Don't use a separate replace-malloc library for the minimal-logalloc test.

https://reviewboard.mozilla.org/r/205268/#review210860
Attachment #8934334 - Flags: review?(n.nethercote) → review+

Comment 18

2 years ago
mozreview-review
Comment on attachment 8934335 [details]
Bug 1423000 - Always log allocator function calls.

https://reviewboard.mozilla.org/r/205270/#review210862

Consistency is good.
Attachment #8934335 - Flags: review?(n.nethercote) → review+

Comment 19

2 years ago
mozreview-review
Comment on attachment 8934336 [details]
Bug 1423000 - Re-run clang-format on memory/build.

https://reviewboard.mozilla.org/r/205272/#review210864

I guess this is fine, but I'm surprised clang-format is touching comments. I thought it didn't do that under the Mozilla configuration?

::: memory/build/mozjemalloc.cpp:1194
(Diff revision 1)
>  
> -// The arena associated with the current thread (per jemalloc_thread_local_arena)
> -// On OSX, __thread/thread_local circles back calling malloc to allocate storage
> -// on first access on each thread, which leads to an infinite loop, but
> -// pthread-based TLS somehow doesn't have this problem.
> +// The arena associated with the current thread (per
> +// jemalloc_thread_local_arena) On OSX, __thread/thread_local circles back
> +// calling malloc to allocate storage on first access on each thread, which
> +// leads to an infinite loop, but pthread-based TLS somehow doesn't have this
> +// problem.

I thought clang-format (in our configuration) didn't touch comments?
Attachment #8934336 - Flags: review?(n.nethercote) → review+

Comment 20

2 years ago
mozreview-review
Comment on attachment 8934337 [details]
Bug 1423000 - Run clang-format in memory/replace/logalloc.

https://reviewboard.mozilla.org/r/205274/#review210866
Attachment #8934337 - Flags: review?(n.nethercote) → review+
Assignee

Comment 21

2 years ago
(In reply to Nicholas Nethercote [:njn] from comment #19)
> I thought clang-format (in our configuration) didn't touch comments?

bug 1414764 removed "ReflowComments: false" from .clang-format.

Comment 22

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/be9b555ba235
Remove Replay::Commit. r=njn
https://hg.mozilla.org/integration/autoland/rev/921cfea08410
Count jemalloc_stats as an operation. r=njn
https://hg.mozilla.org/integration/autoland/rev/7f16eb74e4d4
Move MemSlot lookup for replay results into the Replay methods. r=njn
https://hg.mozilla.org/integration/autoland/rev/4c6d9fbccc0f
Reject some more invalid logalloc replay logs. r=njn
https://hg.mozilla.org/integration/autoland/rev/2b43ef7e2f6d
Move mozjemalloc mutexes to a separate header. r=njn
https://hg.mozilla.org/integration/autoland/rev/62a286838ec6
Use mozjemalloc mutexes in logalloc. r=njn
https://hg.mozilla.org/integration/autoland/rev/eecbbe09235b
Don't use a separate replace-malloc library for the minimal-logalloc test. r=njn
https://hg.mozilla.org/integration/autoland/rev/fb91909e795a
Always log allocator function calls. r=njn
https://hg.mozilla.org/integration/autoland/rev/d0de68944d46
Re-run clang-format on memory/build. r=njn
https://hg.mozilla.org/integration/autoland/rev/1225ddb1e845
Run clang-format in memory/replace/logalloc. r=njn
You need to log in before you can comment on or make changes to this bug.