1423010 - Clean up o.m.g.gfx package

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

We can clean up the gfx package a little, now that the session work in gfx is mostly done.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1423010 - 1. Move BitmapUtils to util package;

I think BitmapUtils is better suited for the o.m.g.util package instead
of o.m.g.gfx, since none of the other classes in gfx actually use
BitmapUtils.

Review commit: https://reviewboard.mozilla.org/r/205278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205278/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1423010 - 2. Fix other code that use BitmapUtils;

Use o.m.g.util.BitmapUtils in code that use BitmapUtils.

Review commit: https://reviewboard.mozilla.org/r/205280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205280/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1423010 - 3. Clean up o.m.g.gfx package;

Remove unused classes and make classes that are not used outside of the
package package-private.

Review commit: https://reviewboard.mozilla.org/r/205282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205282/

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8934342 [details]
Bug 1423010 - 1. Move BitmapUtils to util package;

https://reviewboard.mozilla.org/r/205278/#review210826

Comment 5

[Randall Barker [:rbarker]]

Comment on attachment 8934343 [details]
Bug 1423010 - 2. Fix other code that use BitmapUtils;

https://reviewboard.mozilla.org/r/205280/#review210828

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8934344 [details]
Bug 1423010 - 3. Clean up o.m.g.gfx package;

https://reviewboard.mozilla.org/r/205282/#review210830

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934342 [details]
Bug 1423010 - 1. Move BitmapUtils to util package;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205278/diff/1-2/

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934343 [details]
Bug 1423010 - 2. Fix other code that use BitmapUtils;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205280/diff/1-2/

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934344 [details]
Bug 1423010 - 3. Clean up o.m.g.gfx package;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205282/diff/1-2/

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934342 [details]
Bug 1423010 - 1. Move BitmapUtils to util package;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205278/diff/2-3/

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934343 [details]
Bug 1423010 - 2. Fix other code that use BitmapUtils;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205280/diff/2-3/

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934344 [details]
Bug 1423010 - 3. Clean up o.m.g.gfx package;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205282/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1e2b9928a0e
1. Move BitmapUtils to util package; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/262b9fa1e4b1
2. Fix other code that use BitmapUtils; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/584d39308493
3. Clean up o.m.g.gfx package; r=rbarker

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b1e2b9928a0e
https://hg.mozilla.org/mozilla-central/rev/262b9fa1e4b1
https://hg.mozilla.org/mozilla-central/rev/584d39308493